Description
Agustín Moyano
2020-01-22 23:41:15 UTC
Created attachment 97765 [details] [review] Bub 24487: Regresion test This patch introduces a regresion test where a path parameter is combined with 'contains' match criteria To test: 1. apply this patch 2. prove t/db_dependent/Koha/REST/Plugin/Objects.t Test should fail at this point. Created attachment 97772 [details] [review] Bub 24487: Regresion test This patch introduces a regresion test where a path parameter is combined with 'contains' match criteria To test: 1. apply this patch 2. prove t/db_dependent/Koha/REST/Plugin/Objects.t Test should fail at this point. Created attachment 97774 [details] [review] Bug 24487: Regresion test This patch introduces a regresion test where a path parameter is combined with 'contains' match criteria To test: 1. apply this patch 2. prove t/db_dependent/Koha/REST/Plugin/Objects.t Test should fail at this point. Created attachment 97775 [details] [review] Bug 24487: Don't apply matching criteria to path parameters This patch separates query parameters from path parameters, and uses exact matching for the later. To test: 1. Apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t SUCCESS => tests ok 3. Sign off Created attachment 97782 [details] [review] Bug 24487: Add 2 more tests And make sure tests pass if there is no patron with borrowernumber=10 in DB. luck Luckily, it would only affect plugins using objects.search for now, which hasn't been spotted in the wild. Created attachment 98029 [details] [review] Bug 24487: Regresion test This patch introduces a regresion test where a path parameter is combined with 'contains' match criteria To test: 1. apply this patch 2. prove t/db_dependent/Koha/REST/Plugin/Objects.t Test should fail at this point. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 98030 [details] [review] Bug 24487: Don't apply matching criteria to path parameters This patch separates query parameters from path parameters, and uses exact matching for the later. To test: 1. Apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t SUCCESS => tests ok 3. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 98031 [details] [review] Bug 24487: Add 2 more tests And make sure tests pass if there is no patron with borrowernumber=10 in DB. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Ammended test description Created attachment 98164 [details] [review] Bug 24487: Regresion test This patch introduces a regresion test where a path parameter is combined with 'contains' match criteria To test: 1. apply this patch 2. prove t/db_dependent/Koha/REST/Plugin/Objects.t Test should fail at this point. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 98165 [details] [review] Bug 24487: Don't apply matching criteria to path parameters This patch separates query parameters from path parameters, and uses exact matching for the later. To test: 1. Apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t SUCCESS => tests ok 3. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 98166 [details] [review] Bug 24487: Add 2 more tests And make sure tests pass if there is no patron with borrowernumber=10 in DB. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Ammended test description Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Well done catching this early guys, works as expected and is well tested.. passing qa. Nice work everyone! Pushed to master for 20.05 Does not apply to 19.11.x Not backported Created attachment 103105 [details] [review] [19.11.x] Bug 24487: Regresion test This patch introduces a regresion test where a path parameter is combined with 'contains' match criteria To test: 1. apply this patch 2. prove t/db_dependent/Koha/REST/Plugin/Objects.t Test should fail at this point. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 103106 [details] [review] [19.11.x] Bug 24487: Don't apply matching criteria to path parameters This patch separates query parameters from path parameters, and uses exact matching for the later. To test: 1. Apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t SUCCESS => tests ok 3. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 103107 [details] [review] [19.11.x] Bug 24487: Add 2 more tests And make sure tests pass if there is no patron with borrowernumber=10 in DB. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Ammended test description Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 103142 [details] [review] [19.11.x] Bug 24487: Regresion test This patch introduces a regresion test where a path parameter is combined with 'contains' match criteria To test: 1. apply this patch 2. prove t/db_dependent/Koha/REST/Plugin/Objects.t Test should fail at this point. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 103143 [details] [review] [19.11.x] Bug 24487: Don't apply matching criteria to path parameters This patch separates query parameters from path parameters, and uses exact matching for the later. To test: 1. Apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t SUCCESS => tests ok 3. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 103144 [details] [review] [19.11.x] Bug 24487: Add 2 more tests And make sure tests pass if there is no patron with borrowernumber=10 in DB. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Ammended test description Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Thanks for the rebase! Backported to 19.11.x branch for 19.11.05 |