|
Description
Andrew Fuerste-Henry
2020-01-23 13:00:58 UTC
Created attachment 97872 [details] [review] Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure Cash Registers" and "Configure Items for Purchase" 3) Click both links to ensure you are taken to the relevant config pages. I decided to change the wording on both of the links on the POS page to "Configure Cash Registers" and "Configure Items for Sale". This makes it immediately clear what are the purpose of the two links. To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure Cash Registers" and "Configure Items for Purchase" 3) Click both links to ensure you are taken to the relevant config pages. Created attachment 97879 [details] [review] Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure Cash Registers" and "Configure Items for Purchase" 3) Click both links to ensure you are taken to the relevant config pages. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Looks good, thanks! I am sorry David, but the new text doesn't have the right capitalization. Only the first word of each link should be capitalized (see coding guidelines). Do you want to have a go at fixing this? Let me know if I can help. Btw - I like the new wording much better :) Created attachment 97930 [details] [review] Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure Cash Registers" and "Configure Items for Purchase" 3) Click both links to ensure you are taken to the relevant config pages. Hi Katrin OK, try that instead. Do I need to mark it back to Needs Signoff? I've done that anyway, just in case. Created attachment 97979 [details] [review] Bug 24339: Do not assume there are exactly 3 SIP* AVs Update DB entry 19.06.00.017: We created SIP* AV from accountlines if '^Pay[[:digit:]]{2}$', so I think we should assume that more than SIP00, SIP01, SIP02 can exist. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Comment on attachment 97979 [details] [review] Bug 24339: Do not assume there are exactly 3 SIP* AVs Sorry, didn't drink enough coffee before trying this. Patch didn't apply. I'm confused - are these last three comments relevant to this bug, or have they been attached to the wrong bug? Sorry, that's my fault! The new patch for this bug didn't apply, but I was very slow to realize it. I went to the POS screen, saw that the links were showing the correct capitalization, but didn't realize that was because they were reverting to the original wording. So then I tried to sign off. Because the actual patch hadn't applied, the sandbox just grabbed the most recent patch on there (which was from another bug) and signed it off here. OK thanks - no idea why the patch wouldn't apply. I'll rebase and try again. Created attachment 97985 [details] [review] Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure cash registers" and "Configure items for purchase" 3) Click both links to ensure you are taken to the relevant config pages. Hopefully that is now OK - no idea what went wrong with the last one - the branch I worked on was in a total pickle. Created attachment 97992 [details] [review] Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure cash registers" and "Configure items for purchase" 3) Click both links to ensure you are taken to the relevant config pages. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Ok, actually signing off this time. Thanks! Created attachment 98358 [details] [review] Bug 24490: Clarify wording and function of Purchase Items link on POS This patch changes the wording of the links on the POS side menu To test: 1) Apply the patch 2) Check that the links on the left hand side of the screen read "Configure cash registers" and "Configure items for purchase" 3) Click both links to ensure you are taken to the relevant config pages. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Does not apply to 19.11.x branch not backported |