Summary: | API related tests failing on MySQL8 | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, martin.renvoize, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24590 |
||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 23996 | ||
Attachments: |
Bug 24509: Fix tests failing on MySQL8
Bug 24509: Fix API relared tests failing on MySQL8 |
Description
Jonathan Druart
2020-01-24 10:35:57 UTC
Created attachment 97875 [details] [review] Bug 24509: Fix tests failing on MySQL8 This patch makes a trivial change to the tests so they catch the way MySQL 8 reports the duplicate key message. The difference on the API error message is irrelevant and so it is ok to just make the tests try both MySQL 8 output and the rest of the supported engines. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t \ t/db_dependent/api/v1/libraries.t \ t/db_dependent/api/v1/patrons.t => FAIL: Tests fail due to warning and conflict message differences 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 97880 [details] [review] Bug 24509: Fix API relared tests failing on MySQL8 This patch makes a trivial change to the tests so they catch the way MySQL 8 reports the duplicate key message. The difference on the API error message is irrelevant and so it is ok to just make the tests try both MySQL 8 output and the rest of the supported engines. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t \ t/db_dependent/api/v1/libraries.t \ t/db_dependent/api/v1/patrons.t => FAIL: Tests fail due to warning and conflict message differences 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Thanks Tomas! Nice work everyone! Pushed to master for 20.05 not pushed to 19.11.x branch |