| Summary: | Patron emailer report not using specified email column | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Command-line Utilities | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | 1joynelson, hayleypelham, kelly, lucas, robin |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.03, 19.05.08
|
|
| Circulation function: | |||
| Attachments: |
Bug 24511: Update variable names to avoid confusion
Bug 24511: Update variable names to avoid confusion Bug 24511: Update variable names to avoid confusion |
||
|
Description
Nick Clemens (kidclamp)
2020-01-24 14:58:22 UTC
Created attachment 97884 [details] [review] Bug 24511: Update variable names to avoid confusion To test: 1 - Create a report SELECT borrowernumber, firstname, surname, email, emailpro FROM borrowers WHERE surname='acosta' 2 - Create or edit patron with surname acosta to have a separate email and emailpro 3 - perl misc/cronjobs/patron_emailer --notice HOLDS --module reserves --verbose --email emailpro --report ## --from 'me@you.us' 4 - Note email is used, not email pro 5 - Apply patch 6 - Repeat, correct eamil is used Created attachment 97892 [details] [review] Bug 24511: Update variable names to avoid confusion To test: 1 - Create a report SELECT borrowernumber, firstname, surname, email, emailpro FROM borrowers WHERE surname='acosta' 2 - Create or edit patron with surname acosta to have a separate email and emailpro 3 - perl misc/cronjobs/patron_emailer --notice HOLDS --module reserves --verbose --email emailpro --report ## --from 'me@you.us' 4 - Note email is used, not email pro 5 - Apply patch 6 - Repeat, correct eamil is used Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> The line should be this : perl misc/cronjobs/patron_emailer.pl --notice HOLD --module reserves --verbose --email emailpro --report ## --from 'me@you.us' but it did work as expected. It used the emailpro email when running this cron line. Created attachment 97942 [details] [review] Bug 24511: Update variable names to avoid confusion To test: 1 - Create a report SELECT borrowernumber, firstname, surname, email, emailpro FROM borrowers WHERE surname='acosta' 2 - Create or edit patron with surname acosta to have a separate email and emailpro 3 - perl misc/cronjobs/patron_emailer --notice HOLDS --module reserves --verbose --email emailpro --report ## --from 'me@you.us' 4 - Note email is used, not email pro 5 - Apply patch 6 - Repeat, correct eamil is used Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x for 19.11.03 backported to 19.05.x for 19.05.08 Dependency (script patron_emailer) not present in 18.11, so will not be backported to 18.11.x series. |