| Summary: | Share via Twitter option on OPAC is out of line with rest of Share options | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kelly McElligott <kelly> |
| Component: | OPAC | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
|
Description
Kelly McElligott
2020-01-27 15:28:57 UTC
The tweet link is a Font Awesome icon, but there is also some JavaScript which loads Twitter's version of the button in its place. I must have it blocked in my browser because I didn't see it until I switched to another one.
The solution is to remove the Twitter-specific JS:
Line 1410:
[% IF ( SocialNetworks ) %]
<script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0];if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src="//platform.twitter.com/widgets.js";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script>
[% END %]
|