Description
Martin Renvoize (ashimema)
2020-01-28 14:00:54 UTC
Created attachment 98035 [details] [review] Bug 24525: Remove SIP payment types from point of sale This patch removes the SIP payments types from displaying in the select options on the point of sale payment page. Created attachment 98187 [details] [review] Bug 24525: Remove SIP payment types from point of sale This patch removes the SIP payments types from displaying in the select options on the point of sale payment page. Test plan: 1) Enable the point of sale feature (EnablePointOfSale + UseCashRegisters system preferences) 2) Add a cash register for a library (Home > Point of sale > Cash registers > New cash register) 3) Go to to the point of sale page and select the 'Payment type' drop down list - you should see these payment types: - Cash - Cash via SIP - Creditcard via SIP2 - Visa via SIP2 4) Apply the patch 5) Refresh the point of sale page 6) Now only Cash should be displayed in the drop down list 7) Sign-off the patch! Signed-off-by: David Nind <david@davidnind.com> See bug 24339 comment 19. Created attachment 98547 [details] [review] Bug 24525: Remove SIP payment types from point of sale This patch removes the SIP payments types from displaying in the select options on the point of sale payment page. Signed-off-by: David Nind <david@davidnind.com> Created attachment 98548 [details] [review] Bug 24525: (follow-up) Factor out to an include Followup as requested.. I should just have done it this way in the first place :( Created attachment 98580 [details] [review] Bug 24525: Remove SIP payment types from point of sale This patch removes the SIP payments types from displaying in the select options on the point of sale payment page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 98581 [details] [review] Bug 24525: (follow-up) Factor out to an include Signed-off-by: Nick Clemens <nick@bywatersolutions.com> I don't know if you want to resolve here, or open a new bug. The dropdown for payment type contains an empty option. If you don't select a payment type you get an internal server error. Either that field should be made required, or we shouldn't include a blank option, or a blank shouldn't crash Koha Nice catch nick.. I think that may have come about from the factoring out but I should work out here anti correct it really.. payment type is required if cash registers are in use, otherwise they're optional. I'm sure I can come up with a resolution for that.. will submit a follow-up after the weekend. Created attachment 98641 [details] [review] Bug 24525: (QA follow-up) Make payment type required with cash registers The use of cash registers adds the requirement to enter a payment type, this patch adds the required status when cash registers are configured. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice work everyone! Pushed to master for 20.05 dependencies not in 19.11.x not backported |