Summary: | Show the number of title notes in the tab label on the OPAC detail page | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | OPAC | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, david, jonathan.druart, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.05.00
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 24617 | ||
Attachments: |
Bug 24530: Show a number for title notes on opac-detail
Bug 24530: Show a number for title notes on opac-detail Bug 24530: (QA follow-up) Include Syndetics in notes count Bug 24530: Show a number for title notes on opac-detail Bug 24530: (QA follow-up) Include Syndetics in notes count Bug 24530: (QA follow-up) Add missing filter |
Description
Marcel de Rooy
2020-01-29 13:56:02 UTC
Just wondering about this line in the opac-detail template: [% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %] Where do we fill notes? Cant find that at first. Created attachment 98084 [details] [review] Bug 24530: Show a number for title notes on opac-detail A number (just as on most other tabs) tells more than a boolean (i.e. the tab does not appear for zero marc notes). Intuitively, you might be misled by "Holdings (1), Descriptions" and think there are none. Test plan: Verify that the number of title notes on opac detail page matches your expectations. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 98356 [details] [review] Bug 24530: Show a number for title notes on opac-detail A number (just as on most other tabs) tells more than a boolean (i.e. the tab does not appear for zero marc notes). Intuitively, you might be misled by "Holdings (1), Descriptions" and think there are none. Test plan: Verify that the number of title notes on opac detail page matches your expectations. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> I have no particular view on whether to display the number of title notes or not. (In reply to David Nind from comment #3) > Signed-off-by: David Nind <david@davidnind.com> Thanks I have some worries about this one: - Changes only OPAC, not staff - Might show a false 0 in some context: [% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %] <li id="tab_descriptions"> <a href="#descriptions">Title notes ( [% MARCNOTES.size %] )</a></li> If there are notes and/or Syndetics content, but no MARCNOTES, the tab will display 0, looking 'empty' to the patrons. I think the nicest way might be to include the Syndetics and note content in the number. If we can't tell for syndetics, maybe we could do something like: 1+ 5 5xx displaying + Syndetics content available = 5+ ? Or only show the number if Syndetics is not active. (In reply to Marcel de Rooy from comment #1) > Just wondering about this line in the opac-detail template: > > [% IF ( MARCNOTES || notes || ( SyndeticsEnabled && > SyndeticsSummary && SYNDETICS_SUMMARY )) %] > > Where do we fill notes? Cant find that at first. notes is coming from biblio.notes; but still cant find the place where it is passed into the template (In reply to Katrin Fischer from comment #7) > I think the nicest way might be to include the Syndetics and note content in > the number. If we can't tell for syndetics, maybe we could do something > like: 1+ > > 5 5xx displaying + Syndetics content available = 5+ ? > > Or only show the number if Syndetics is not active. If there is a Syndetics summary, I will add +1. It is a html blob. Created attachment 98635 [details] [review] Bug 24530: (QA follow-up) Include Syndetics in notes count Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested by enabling the prefs and passing contents to the template var. (In reply to Katrin Fischer from comment #6) Thanks for QAing. > - Changes only OPAC, not staff Will open a new report for that. > - Might show a false 0 in some context: > > [% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && > SYNDETICS_SUMMARY )) %] > <li id="tab_descriptions"> <a href="#descriptions">Title notes ( [% > MARCNOTES.size %] )</a></li> > > If there are notes and/or Syndetics content, but no MARCNOTES, the tab will > display 0, looking 'empty' to the patrons. Good point. Adjusted in follow-up. Created attachment 98992 [details] [review] Bug 24530: Show a number for title notes on opac-detail A number (just as on most other tabs) tells more than a boolean (i.e. the tab does not appear for zero marc notes). Intuitively, you might be misled by "Holdings (1), Descriptions" and think there are none. Test plan: Verify that the number of title notes on opac detail page matches your expectations. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 98993 [details] [review] Bug 24530: (QA follow-up) Include Syndetics in notes count Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested by enabling the prefs and passing contents to the template var. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Hope to see a patch for bug 24617 soon too :) (In reply to Katrin Fischer from comment #12) > Signed-off-by: David Nind <david@davidnind.com> > Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thx David and Katrin Nice work everyone! Pushed to master for 20.05 Jenkins is complaining about a missing filter: xt/find-missing-filters.t, koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt line 573 Created attachment 99091 [details] [review] Bug 24530: (QA follow-up) Add missing filter Jenkins is complaining about a missing filter: xt/find-missing-filters.t, koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt line 573 The variable is just filled in the template but lets make Jenkins happy. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Followup pushed, thanks Marcel.. you beat me to it :) Enhancement not pushed to 19.11.x |