| Summary: | Club/Hold.t has a wrong call to build_sample_item | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | 1joynelson, lucas, tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.03
|
|
| Circulation function: | |||
| Bug Depends on: | 19618 | ||
| Bug Blocks: | 24363 | ||
| Attachments: |
Bug 24546: Fix intentions of build_sample_item in Club/Hold.t
Bug 24546: Fix intentions of build_sample_item in Club/Hold.t Bug 24546: Fix intentions of build_sample_item in Club/Hold.t |
||
Coming from commit 474eca3dbcabe40eead066c3221d4984b0b890b4 Bug 19618: Add tests Created attachment 98160 [details] [review] Bug 24546: Fix intentions of build_sample_item in Club/Hold.t In t/db_dependent/Koha/Club/Hold.t: my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode }); my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode }); build_sample_item takes either "library" or the item's attributes. branchcode is not part of the item's table, so what those 2 lines are trying to acchieve is wrong. Test plan: % prove t/db_dependent/Koha/Club/Hold.t must return green before and after this patch Note that this patch also remove an uneeded debugging statement. This has been caught by bug 24363. Created attachment 98216 [details] [review] Bug 24546: Fix intentions of build_sample_item in Club/Hold.t In t/db_dependent/Koha/Club/Hold.t: my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode }); my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode }); build_sample_item takes either "library" or the item's attributes. branchcode is not part of the item's table, so what those 2 lines are trying to acchieve is wrong. Test plan: % prove t/db_dependent/Koha/Club/Hold.t must return green before and after this patch Note that this patch also remove an uneeded debugging statement. This has been caught by bug 24363. Signed-off-by: David Nind <david@davidnind.com> Created attachment 98227 [details] [review] Bug 24546: Fix intentions of build_sample_item in Club/Hold.t In t/db_dependent/Koha/Club/Hold.t: my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode }); my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode }); build_sample_item takes either "library" or the item's attributes. branchcode is not part of the item's table, so what those 2 lines are trying to acchieve is wrong. Test plan: % prove t/db_dependent/Koha/Club/Hold.t must return green before and after this patch Note that this patch also remove an uneeded debugging statement. This has been caught by bug 24363. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.03 missing dependencies for 19.05.x, no backport |
In t/db_dependent/Koha/Club/Hold.t: my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode }); my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode }); build_sample_item takes either "library" or the item's attributes. branchcode is not part of the item's table, so what those 2 lines are trying to acchieve is wrong.