Bug 24582

Summary: Cloning circ rules does not maintain checkouts allowed or on-site checkouts allowed
Product: Koha Reporter: Andrew Fuerste-Henry <andrew>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: CLOSED WORKSFORME QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: daniel.gaghan, gmcharlt, jonathan.druart, kyle, margaret, nick
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Crowdfunding committed: 0
Crowdfunding contact: Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05
Circulation function:

Description Andrew Fuerste-Henry 2020-02-04 21:16:00 UTC
When cloning circ rules to a branch, Koha clones the issuingrules table but not the circulation_rules table. That means all the created rules have Unlimited for number of checkouts and onsite checkouts allowed. That's not great.
Comment 1 Jonathan Druart 2020-02-05 09:47:12 UTC
Which versions? I would like to know if it's a new thing (since bug 18936) or affect stable releases.
Comment 2 Andrew Fuerste-Henry 2020-02-05 13:03:43 UTC
I found this in 19.05 and confirmed it in master. Thanks!
Comment 3 Jonathan Druart 2020-02-11 16:34:07 UTC
Andrew, I do not recreate on master.
Can you confirm it is fixed?
Otherwise can you provide a step-by-step plan to recreate the issue?
Comment 4 Andrew Fuerste-Henry 2020-02-11 20:30:22 UTC
Can no longer replicate on master. Nevermind!