Description
Bernardo Gonzalez Kriegel
2020-02-04 22:29:59 UTC
Created attachment 98414 [details] [review] Bug 24583: Rewrite mandatory/auth_values to YAML YAML version of mandatory auth_values. To test: 1) Do a clean install, dump auth_values, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files Created attachment 98415 [details] [review] Bug 24583: Rewrite mandatory/class_sources to YAML YAML version of mandatory class_sources To test: 1) Same test plan of first patch, only check tables class_sort_rules, class_split_rules and class_sources Created attachment 98416 [details] [review] Bug 24583: Rewrite mandatory/sample_frequencies to YAML YAML version of mandatory sample_frequencies To test: 1) Same test plan of first patch, only check table subscription_frequencies Created attachment 98417 [details] [review] Bug 24583: Rewrite mandatory/sample_notices to YAML YAML version of mandatory sample_notices To test: 1) Same test plan of first patch, only check table letter Created attachment 98418 [details] [review] Bug 24583: Rewrite mandatory/sample_numberpatterns to YAML YAML version of mandatory sample_numberpatterns To test: 1) Same test plan of first patch, only check table subscription_numberpatterns Created attachment 99397 [details] [review] Bug 24583: Rewrite mandatory/auth_values to YAML YAML version of mandatory auth_values. To test: 1) Do a clean install, dump auth_values, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 99398 [details] [review] Bug 24583: Rewrite mandatory/class_sources to YAML YAML version of mandatory class_sources To test: 1) Same test plan of first patch, only check tables class_sort_rules, class_split_rules and class_sources Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 99399 [details] [review] Bug 24583: Rewrite mandatory/sample_frequencies to YAML YAML version of mandatory sample_frequencies To test: 1) Same test plan of first patch, only check table subscription_frequencies Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 99400 [details] [review] Bug 24583: Rewrite mandatory/sample_notices to YAML YAML version of mandatory sample_notices To test: 1) Same test plan of first patch, only check table letter Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 99401 [details] [review] Bug 24583: Rewrite mandatory/sample_numberpatterns to YAML YAML version of mandatory sample_numberpatterns To test: 1) Same test plan of first patch, only check table subscription_numberpatterns Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Great work Bernardo, looks solid to me and installs fine. Signing off. Created attachment 100195 [details] [review] Bug 24583: (followup) restore null values to labels This patch adds null values to selected label2/3 in sample numberpatterns Created attachment 100346 [details] [review] Bug 24583: Rewrite mandatory/auth_values to YAML YAML version of mandatory auth_values. To test: 1) Do a clean install, dump auth_values, reserve. 2) Apply this patch and it's dependencies 3) Do a clean install, dump again and compare No differences expected 4) Try translation a) Go to misc/translator b) create files for a new language ./translate create xx-YY c) Check new file po/xx-YY-instaler.po Verify strings from this file. d) Install new language ./translate install xx-YY e) Try clean install with new files Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 100347 [details] [review] Bug 24583: Rewrite mandatory/class_sources to YAML YAML version of mandatory class_sources To test: 1) Same test plan of first patch, only check tables class_sort_rules, class_split_rules and class_sources Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 100348 [details] [review] Bug 24583: Rewrite mandatory/sample_frequencies to YAML YAML version of mandatory sample_frequencies To test: 1) Same test plan of first patch, only check table subscription_frequencies Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 100349 [details] [review] Bug 24583: Rewrite mandatory/sample_notices to YAML YAML version of mandatory sample_notices To test: 1) Same test plan of first patch, only check table letter Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 100350 [details] [review] Bug 24583: Rewrite mandatory/sample_numberpatterns to YAML YAML version of mandatory sample_numberpatterns To test: 1) Same test plan of first patch, only check table subscription_numberpatterns Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 100351 [details] [review] Bug 24583: (followup) restore null values to labels This patch adds null values to selected label2/3 in sample numberpatterns Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 Created attachment 100389 [details] [review] Bug 24583: adjust xt/sample_notices.t Created attachment 100391 [details] [review] Bug 24583: adjust xt/sample_notices.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x |