Bug 24595

Summary:	Warnings displayed by Circulation.t
Product:	Koha	Reporter:	Jonathan Druart <jonathan.druart>
Component:	Architecture, internals, and plumbing	Assignee:	Jonathan Druart <jonathan.druart>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	1joynelson, martin.renvoize
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	20.05.00
Circulation function:
Bug Depends on:	24217
Bug Blocks:
Attachments:	Bug 24595: Silent warnings from Circulation.t Bug 24595: Silent warnings from Circulation.t

Description Jonathan Druart 2020-02-05 13:29:07 UTC

kohadev-koha@9bbf9ac68519:/kohadevbox/koha$ prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 1/46 Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787.
t/db_dependent/Circulation.t .. 15/46 Use of uninitialized value $due in regexp compilation at /kohadevbox/koha/C4/Overdues.pm line 549.
t/db_dependent/Circulation.t .. 18/46 Use of uninitialized value $due in regexp compilation at /kohadevbox/koha/C4/Overdues.pm line 549.
Use of uninitialized value $due in concatenation (.) or string at /kohadevbox/koha/C4/Overdues.pm line 601.
Use of uninitialized value $due in regexp compilation at /kohadevbox/koha/C4/Overdues.pm line 549.
t/db_dependent/Circulation.t .. 27/46 Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2297.
Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2297.
Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2297.
Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Circulation.pm line 2297.
t/db_dependent/Circulation.t .. 30/46 Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787.
t/db_dependent/Circulation.t .. 31/46 Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787.
Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787.
Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787.
Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787.
Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Circulation.pm line 3787.
t/db_dependent/Circulation.t .. 38/46 Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/C4/Circulation.pm line 962.
t/db_dependent/Circulation.t .. 44/46 Use of uninitialized value $due in regexp compilation at /kohadevbox/koha/C4/Overdues.pm line 549.
Use of uninitialized value $due in concatenation (.) or string at /kohadevbox/koha/C4/Overdues.pm line 601.
t/db_dependent/Circulation.t .. ok
All tests successful.
Files=1, Tests=46, 32 wallclock secs ( 0.07 usr  0.01 sys + 20.75 cusr  7.61 csys = 28.44 CPU)
Result: PASS

Comment 1 Jonathan Druart 2020-02-05 13:30:02 UTC

Created attachment 98480 [details] [review]
Bug 24595: Silent warnings from Circulation.t

Comment 2 Martin Renvoize (ashimema) 2020-02-05 14:17:42 UTC

Created attachment 98493 [details] [review]
Bug 24595: Silent warnings from Circulation.t

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 3 Martin Renvoize (ashimema) 2020-02-05 14:18:00 UTC

Sweet silence.. Passing QA

Comment 4 Martin Renvoize (ashimema) 2020-02-05 14:28:37 UTC

Nice work everyone!

Pushed to master for 20.05

Comment 5 Joy Nelson 2020-02-11 00:27:20 UTC

missing dependencies in 19.11.x
not backported