Summary: | Phase out jquery.cookie.js: Basic MARC editor | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | 1joynelson, lucas, martin.renvoize, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.04, 19.05.09
|
|
Circulation function: | |||
Bug Depends on: | 23944 | ||
Bug Blocks: | 27750 | ||
Attachments: |
Bug 24621: Phase out jquery.cookie.js: Basic MARC editor
Bug 24621: Phase out jquery.cookie.js: Basic MARC editor Bug 24621: Phase out jquery.cookie.js: Basic MARC editor |
Description
Owen Leonard
2020-02-10 19:01:36 UTC
Created attachment 98684 [details] [review] Bug 24621: Phase out jquery.cookie.js: Basic MARC editor This patch removes the use of the jquery.cookie plugin by the basic MARC editor for setting two interface preferences: Showing MARC tag numbers and showing MARC documentation links. To test, apply tThiss he patch and open the basic MARC editor. - From the "Settings" menu, select the "Show MARC tag documentation links" link. This should toggle the display of the "?" link next to MARC tag descriptions. - Reload the page to confirm that your selection has been saved. - Perform the same test with the "Show tags" menu item. You can also follow the changes to the cookie using the browser's developer console. Look for cookies named 'marcdocs_***' and 'marctags_***' (where *** is the borrowernumber of the logged-in user) and confirm that the value of each flips from "show" to "hide" and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies Created attachment 98919 [details] [review] Bug 24621: Phase out jquery.cookie.js: Basic MARC editor This patch removes the use of the jquery.cookie plugin by the basic MARC editor for setting two interface preferences: Showing MARC tag numbers and showing MARC documentation links. To test, apply this patch and open the basic MARC editor. - From the "Settings" menu, select the "Show MARC tag documentation links" link. This should toggle the display of the "?" link next to MARC tag descriptions. - Reload the page to confirm that your selection has been saved. - Perform the same test with the "Show tags" menu item. You can also follow the changes to the cookie using the browser's developer console. Look for cookies named 'marcdocs_***' and 'marctags_***' (where *** is the borrowernumber of the logged-in user) and confirm that the value of each flips from "show" to "hide" and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies Signed-off-by: David Nind <david@davidnind.com> Created attachment 98955 [details] [review] Bug 24621: Phase out jquery.cookie.js: Basic MARC editor This patch removes the use of the jquery.cookie plugin by the basic MARC editor for setting two interface preferences: Showing MARC tag numbers and showing MARC documentation links. To test, apply the patch and open the basic MARC editor. - From the "Settings" menu, select the "Show MARC tag documentation links" link. This should toggle the display of the "?" link next to MARC tag descriptions. - Reload the page to confirm that your selection has been saved. - Perform the same test with the "Show tags" menu item. You can also follow the changes to the cookie using the browser's developer console. Look for cookies named 'marcdocs_***' and 'marctags_***' (where *** is the borrowernumber of the logged-in user) and confirm that the value of each flips from "show" to "hide" and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x for 19.11.04 backported to 19.05.x for 19.05.09 |