Summary: | Koha::DateUtils::dt_from_string rfc3339 cannot handle high precision seconds | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Isherwood <bugzilla> |
Component: | Architecture, internals, and plumbing | Assignee: | Andrew Isherwood <bugzilla> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, jonathan.druart, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.04, 19.05.09
|
|
Bug Depends on: | 18330 | ||
Bug Blocks: | 24850 | ||
Attachments: |
Bug 24643: Support fractional seconds
Add unit tests Bug 24643: Add unit tests Bug 24643: Support fractional seconds Bug 24643: Add unit tests Bug 24643: Support fractional seconds Bug 24643: Add unit tests Bug 24643: Add test to cover the timezone |
Description
Andrew Isherwood
2020-02-12 16:02:15 UTC
Created attachment 98762 [details] [review] Bug 24643: Support fractional seconds This patch allows dt_from_string to handle RFC3339 strings containing fractional seconds up to one thousandth of a second. Test plan: - Apply patch - prove t/DateUtils.t Created attachment 98763 [details] [review] Add unit tests Created attachment 98764 [details] [review] Bug 24643: Add unit tests Created attachment 98780 [details] [review] Bug 24643: Support fractional seconds This patch allows dt_from_string to handle RFC3339 strings containing fractional seconds up to one thousandth of a second. Test plan: - Apply patch - prove t/DateUtils.t Signed-off-by: David Nind <david@davidnind.com> Created attachment 98781 [details] [review] Bug 24643: Add unit tests https://bugs.koha-community.org/show_bug.cgi?id=24643 Signed-off-by: David Nind <david@davidnind.com> Created attachment 98825 [details] [review] Bug 24643: Support fractional seconds This patch allows dt_from_string to handle RFC3339 strings containing fractional seconds up to one thousandth of a second. Test plan: - Apply patch - prove t/DateUtils.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 98826 [details] [review] Bug 24643: Add unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 98827 [details] [review] Bug 24643: Add test to cover the timezone Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.04 backported to 19.05.x for 19.05.09 |