|
Description
Nick Clemens (kidclamp)
2020-02-12 18:43:51 UTC
Created attachment 98771 [details] [review] Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under 'Fines Policy' Created attachment 99064 [details] [review] Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under 'Fines Policy' Signed-off-by: David Nind <david@davidnind.com> Hi Nick, it looks like this patch needs a clean-up (check the diff, you will see) Created attachment 99234 [details] [review] Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under 'Fines Policy' Signed-off-by: David Nind <david@davidnind.com> Thx! Is this 'just fines' or payments in general? If it's payments in general perhaps it should live under the new 'Accounting' tab instead, under the 'Policy' section? Created attachment 99293 [details] [review] Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under Accounting -> Policy Created attachment 99459 [details] [review] Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under Accounting -> Policy Signed-off-by: David Nind <david@davidnind.com> Created attachment 99464 [details] [review] Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under Accounting -> Policy Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 does not apply to 19.11.x please rebase if needed Created attachment 100685 [details] [review] Bug 24646: [19.11.x] Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under Accounting -> Policy Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> |