Bug 24647

Summary:	PDF::API2::Simple is declared as a required dependency but it is not used
Product:	Koha	Reporter:	Julian Maurice <julian.maurice>
Component:	Architecture, internals, and plumbing	Assignee:	Julian Maurice <julian.maurice>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	1joynelson
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	20.05.00
Circulation function:
Attachments:	Bug 24647: Remove PDF::API2::Simple from cpanfile Bug 24647: Remove PDF::API2::Simple from cpanfile Bug 24647: Remove PDF::API2::Simple from cpanfile

Description Julian Maurice 2020-02-12 20:24:40 UTC

`git grep PDF::API2::Simple` returns only one occurence, in cpanfile.

`git log -S PDF::API2::Simple` returns a few commits that move around the declaration of dependencies, and the commit https://github.com/Koha-Community/Koha/commit/e418db57f9544983a004b6a7b7f79ab5bdcb30a0 that introduces this dependency without using it.

So it looks like it has been a required dependency for 10 years, without ever being used.

Comment 1 Julian Maurice 2020-02-12 20:28:32 UTC

Created attachment 98777 [details] [review]
Bug 24647: Remove PDF::API2::Simple from cpanfile

It is not used anywhere.

Also, remove PDF::API2::Page and PDF::API2::Util from cpanfile.
These modules are included in PDF::API2 which is already in cpanfile.

Comment 2 David Nind 2020-02-17 07:09:41 UTC

Created attachment 99067 [details] [review]
Bug 24647: Remove PDF::API2::Simple from cpanfile

It is not used anywhere.

Also, remove PDF::API2::Page and PDF::API2::Util from cpanfile.
These modules are included in PDF::API2 which is already in cpanfile.

Test plan:
1) Search for PDF::API2::Simple - git grep PDF::API2::Simple - there 
   should be one result
2) Apply the patch
3) Search again
4) There should be no results
5) Sign off!

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Katrin Fischer 2020-02-17 20:06:12 UTC

Created attachment 99128 [details] [review]
Bug 24647: Remove PDF::API2::Simple from cpanfile

It is not used anywhere.

Also, remove PDF::API2::Page and PDF::API2::Util from cpanfile.
These modules are included in PDF::API2 which is already in cpanfile.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Martin Renvoize (ashimema) 2020-02-19 11:35:04 UTC

Nice work everyone!

Pushed to master for 20.05

Comment 5 Joy Nelson 2020-03-05 01:58:31 UTC

does not apply to 19.11.x 
cpanfile does not contain the lines indicated to be removed anyways!
not backporting