Bug 24649

Summary:	Cloning item subfields misses a <li> tag
Product:	Koha	Reporter:	Marcel de Rooy <m.de.rooy>
Component:	Staff interface	Assignee:	Marcel de Rooy <m.de.rooy>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	1joynelson, aleisha, gmcharlt, lucas
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13574
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	20.05.00, 19.11.04, 19.05.09
Circulation function:
Attachments:	Bug 24649: Cloning item subfields misses a <li> tag Spacing between cloned subfields Bug 24649: Fix missing <li> tag on item editor for cloned subfield Bug 24649: Fix missing <li> tag on batch mod item for cloned subfield Bug 24649: Fix two other missing <li> tags for cloned subfields Bug 24649: Fix missing <li> tag on item editor for cloned subfield Bug 24649: Fix two other missing <li> tags for cloned subfields Bug 24649: Fix two other missing <li> tags for cloned subfields Bug 24649: Fix missing <li> tag on item editor for cloned subfield Bug 24649: Fix two other missing <li> tags for cloned subfields

Description Marcel de Rooy 2020-02-13 08:42:13 UTC

Mark an item subfield like URI as repeatable. And clone it in the item editor. You see some styling issues.

Comment 1 Marcel de Rooy 2020-02-13 09:10:29 UTC Comment hidden (obsolete)

Created attachment 98794 [details] [review]
Bug 24649: Cloning item subfields misses a <li> tag

Instead of the parentNode (which is a div), we need the parent of the div
(which is a li).
So a simple fix.

Test plan:
Mark item subfield URI repeatable.
Clone the subfield.
Notice the difference between patch applied or not applied.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 2 Marcel de Rooy 2020-02-13 09:25:17 UTC

Created attachment 98795 [details]
Spacing between cloned subfields

Comment 3 Marcel de Rooy 2020-02-13 09:37:38 UTC

Created attachment 98797 [details] [review]
Bug 24649: Fix missing <li> tag on item editor for cloned subfield

Instead of the parentNode (which is a div), we need the parent of the div
(which is a li).
So a simple fix.

Test plan:
To see the difference, test first without patch applied:
Mark item subfield, say URI, as repeatable.
Clone that subfield in item editor.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 4 Marcel de Rooy 2020-02-13 09:37:42 UTC Comment hidden (obsolete)

Created attachment 98798 [details] [review]
Bug 24649: Fix missing <li> tag on batch mod item for cloned subfield

Same problem as previous patch.

Test plan:
Go to Tools/Batch item modification.
Test cloning subfield on batchMod-edit.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 5 Marcel de Rooy 2020-02-13 09:41:25 UTC

Left one small thing on serials/serials-edit.
Cloning on serial edit works, but the spacing between the original and cloned subfield is different from normal. See the attached image.
Owen: Any chance to add a patch here for styling?

Comment 6 Owen Leonard 2020-02-13 13:09:56 UTC

Marcel I don't think it's a styling issue. I think serials-edit.tt needs the same correction you made to additem.tt and batchMod-edit.tt.

Comment 7 Marcel de Rooy 2020-02-13 13:39:04 UTC

Created attachment 98829 [details] [review]
Bug 24649: Fix two other missing <li> tags for cloned subfields

Same problem as previous patch in Batch item modification as well as
serial-edit.pl.

Test plan:
[1] Go to Tools/Batch item modification.
    Test cloning subfield on batchMod-edit.
[2] Go to a serial with "Create item when receiving".
    Receive an issue. Click add item.
    Test cloning subfield.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 8 Marcel de Rooy 2020-02-13 13:39:36 UTC

(In reply to Owen Leonard from comment #6)
> Marcel I don't think it's a styling issue. I think serials-edit.tt needs the
> same correction you made to additem.tt and batchMod-edit.tt.

Thanks. You are right.

Comment 9 Aleisha Amohia 2020-02-13 20:16:46 UTC

Created attachment 98887 [details] [review]
Bug 24649: Fix missing <li> tag on item editor for cloned subfield

Instead of the parentNode (which is a div), we need the parent of the div
(which is a li).
So a simple fix.

Test plan:
To see the difference, test first without patch applied:
Mark item subfield, say URI, as repeatable.
Clone that subfield in item editor.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>

Comment 10 Aleisha Amohia 2020-02-13 20:16:54 UTC

Created attachment 98888 [details] [review]
Bug 24649: Fix two other missing <li> tags for cloned subfields

Same problem as previous patch in Batch item modification as well as
serial-edit.pl.

Test plan:
[1] Go to Tools/Batch item modification.
    Test cloning subfield on batchMod-edit.
[2] Go to a serial with "Create item when receiving".
    Receive an issue. Click add item.
    Test cloning subfield.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>

Comment 11 Katrin Fischer 2020-02-14 14:42:01 UTC

Created attachment 98949 [details] [review]
Bug 24649: Fix two other missing <li> tags for cloned subfields

Same problem as previous patch in Batch item modification as well as
serial-edit.pl.

Test plan:
[1] Go to Tools/Batch item modification.
    Test cloning subfield on batchMod-edit.
[2] Go to a serial with "Create item when receiving".
    Receive an issue. Click add item.
    Test cloning subfield.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 12 Katrin Fischer 2020-02-14 14:56:12 UTC

Created attachment 98958 [details] [review]
Bug 24649: Fix missing <li> tag on item editor for cloned subfield

Instead of the parentNode (which is a div), we need the parent of the div
(which is a li).
So a simple fix.

Test plan:
To see the difference, test first without patch applied:
Mark item subfield, say URI, as repeatable.
Clone that subfield in item editor.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 13 Katrin Fischer 2020-02-14 14:56:16 UTC

Created attachment 98959 [details] [review]
Bug 24649: Fix two other missing <li> tags for cloned subfields

Same problem as previous patch in Batch item modification as well as
serial-edit.pl.

Test plan:
[1] Go to Tools/Batch item modification.
    Test cloning subfield on batchMod-edit.
[2] Go to a serial with "Create item when receiving".
    Receive an issue. Click add item.
    Test cloning subfield.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 14 Marcel de Rooy 2020-02-17 07:36:12 UTC

(In reply to Katrin Fischer from comment #13)
> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Thx Aleisha and Katrin

Comment 15 Martin Renvoize (ashimema) 2020-02-17 10:46:10 UTC

Nice work everyone!

Pushed to master for 20.05

Comment 16 Joy Nelson 2020-03-05 01:22:06 UTC

Pushed to 19.11.x branch for 19.11.04

Comment 17 Lucas Gass (lukeg) 2020-03-09 20:29:23 UTC

backported to 19.05.x for 19.05.09