|
Description
Kelly McElligott
2020-02-14 14:49:12 UTC
This is going to be a big problem for us. We don't link the guarantors at all. I'm changing this from enhancement because on 19.05 we can see non-koha guarantors on the patron detail page. Created attachment 99089 [details] [review] Bug 24666: Display not registered guarantors on the patron detail page There was no way to see the not registered guarantors apart of editing the patron. Test plan: - Create a patron with category type "Child" - Define a "guarantor surname" and/or "guarantor firstname" in the "Contact" block (the patron is not registered) - See the patron's detail page and notice that the info appear - Edit and add a registered guarantor - See the patron's detail page and notice that the 2 guarantors info appear Note that the relationship has been added. Created attachment 99184 [details] [review] Bug 24666: Display not registered guarantors on the patron detail page There was no way to see the not registered guarantors apart of editing the patron. Test plan: - Create a patron with category type "Child" - Define a "guarantor surname" and/or "guarantor firstname" in the "Contact" block (the patron is not registered) - See the patron's detail page and notice that the info appear - Edit and add a registered guarantor - See the patron's detail page and notice that the 2 guarantors info appear Note that the relationship has been added. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 99185 [details] [review] Bug 24666: Display not registered guarantors on the patron detail page There was no way to see the not registered guarantors apart of editing the patron. Test plan: - Create a patron with category type "Child" - Define a "guarantor surname" and/or "guarantor firstname" in the "Contact" block (the patron is not registered) - See the patron's detail page and notice that the info appear - Edit and add a registered guarantor - See the patron's detail page and notice that the 2 guarantors info appear Note that the relationship has been added. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 99197 [details] [review] Bug 24666: Display not registered guarantors on the patron detail page There was no way to see the not registered guarantors apart of editing the patron. Test plan: - Create a patron with category type "Child" - Define a "guarantor surname" and/or "guarantor firstname" in the "Contact" block (the patron is not registered) - See the patron's detail page and notice that the info appear - Edit and add a registered guarantor - See the patron's detail page and notice that the 2 guarantors info appear Note that the relationship has been added. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 99212 [details] [review] Bug 24666: (QA follow-up) Add missing filters Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as expected, resolves a regression. QA follow-up added to fix filter errors, but otherwise no issues found. Passing QA Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.04 |