| Summary: | opac-auth.tt contains trivial HTML error | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | OPAC | Assignee: | David Cook <dcook> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | 1joynelson, lucas, martin.renvoize, sally.healey |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: |
20.05.00, 19.11.04, 19.05.09
|
Circulation function: | |
| Attachments: |
Bug 24676: Remove <p/> typo in opac-auth.tt
Bug 24676: Remove <p/> typo in opac-auth.tt Bug 24676: Remove <p/> typo in opac-auth.tt |
||
|
Description
David Cook
2020-02-18 00:56:52 UTC
Created attachment 99140 [details] [review] Bug 24676: Remove <p/> typo in opac-auth.tt This patch removes some trivial invalid HTML from opac-auth.tt Test plan: 1. Apply patch 2. As an unauthenticated user, try to place a hold on a search result e.g. http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=29 3. View source or use an inspector to see there is no <p></p> block between <input type="submit" value="Log in" class="btn"> and <div id="nologininstructions"> Created attachment 99326 [details] [review] Bug 24676: Remove <p/> typo in opac-auth.tt This patch removes some trivial invalid HTML from opac-auth.tt Test plan: 1. Apply patch 2. As an unauthenticated user, try to place a hold on a search result e.g. http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=29 3. View source or use an inspector to see there is no <p></p> block between <input type="submit" value="Log in" class="btn"> and <div id="nologininstructions"> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 99340 [details] [review] Bug 24676: Remove <p/> typo in opac-auth.tt This patch removes some trivial invalid HTML from opac-auth.tt Test plan: 1. Apply patch 2. As an unauthenticated user, try to place a hold on a search result e.g. http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=29 3. View source or use an inspector to see there is no <p></p> block between <input type="submit" value="Log in" class="btn"> and <div id="nologininstructions"> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial fix passes all tests.. passing qa Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x for 19.11.04 backported to 19.05.x for 19.05.09 |