Summary: | Make OPACPopupAuthorsSearch work with search terms containing parenthesis | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, fridolin.somers, jesse, lucas, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the OPAC so that when OPACPopupAuthorsSearch is enabled, author names not linked to an authority record that have parenthesis (for example, Criterion Collection (Firm)) correctly return results. Previously, author names with parenthesis did not return search results.
|
Version(s) released in: |
24.11.00,24.05.06,23.11.11
|
Circulation function: | |||
Bug Depends on: | 13327 | ||
Bug Blocks: | |||
Attachments: |
Bug 24690: Make OPACPopupAuthorsSearch work with search terms containing parenthesis
MARC file containing records for testing Bug 24690: Make OPACPopupAuthorsSearch work with search terms containing parenthesis Bug 24690: Make OPACPopupAuthorsSearch work with search terms containing parenthesis |
Description
Katrin Fischer
2020-02-20 07:05:36 UTC
Created attachment 168315 [details] [review] Bug 24690: Make OPACPopupAuthorsSearch work with search terms containing parenthesis This patch updates the OPACPopupAuthorSearch feature so that it wraps search terms with quotes. This is the behavior we have in place for author searches outside the context of OPACPopupAuthorSearch, e.g. 'au:"Criterion Collection (Firm)"' To test, apply the patch and enable the OPACPopupAuthorSearch system preference. - Search for a record in the OPAC which has author data containing parentheses (it should not be a field linked to an authority record). - View the detail page for that record. - Click on one of the problematic author links. - This should trigger a modal window with a list of authors and checkboxes for each. - With just the single checkbox checked, click "Search." - The search should return the correct results. - Test other author searches to confirm that they work too. Sponsored-by: Athens County Public Libraries Created attachment 168316 [details]
MARC file containing records for testing
This file will give you records containing the author "Criterion Collection (firm)" (not an authority record link) with which to test
Created attachment 168334 [details] [review] Bug 24690: Make OPACPopupAuthorsSearch work with search terms containing parenthesis This patch updates the OPACPopupAuthorsSearch feature so that it wraps search terms with quotes. This is the behavior we have in place for author searches outside the context of OPACPopupAuthorisSearch, e.g. 'au:"Criterion Collection (Firm)"' To test, apply the patch and enable the OPACPopupAuthorsSearch system preference. - Search for a record in the OPAC which has author data containing parentheses (it should not be a field linked to an authority record). - View the detail page for that record. - Click on one of the problematic author links. - This should trigger a modal window with a list of authors and checkboxes for each. - With just the single checkbox checked, click "Search." - The search should return the correct results. - Test other author searches to confirm that they work too. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. I amended the patch commit message - OPACPopupAuthorSearch ==> OPACPopupAuthorsSearch (added s for Authors). 2. Thanks for providing the sample records! Created attachment 174549 [details] [review] Bug 24690: Make OPACPopupAuthorsSearch work with search terms containing parenthesis This patch updates the OPACPopupAuthorsSearch feature so that it wraps search terms with quotes. This is the behavior we have in place for author searches outside the context of OPACPopupAuthorisSearch, e.g. 'au:"Criterion Collection (Firm)"' To test, apply the patch and enable the OPACPopupAuthorsSearch system preference. - Search for a record in the OPAC which has author data containing parentheses (it should not be a field linked to an authority record). - View the detail page for that record. - Click on one of the problematic author links. - This should trigger a modal window with a list of authors and checkboxes for each. - With just the single checkbox checked, click "Search." - The search should return the correct results. - Test other author searches to confirm that they work too. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 Pushed to 23.11.x for 23.11.11 Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. |