Summary: | Split items.uri on staff detail view | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Staff interface | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, aleisha, gmcharlt, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 |
||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
Circulation function: | |||
Attachments: |
Bug 24697: Split items.uri on staff detail view
Bug 24697: Split items.uri on staff detail view Bug 24697: Split items.uri on staff detail view Bug 24697: Split items.uri on staff detail view |
Description
Marcel de Rooy
2020-02-20 11:12:37 UTC
Created attachment 99308 [details] [review] Bug 24697: Split items.uri on staff detail view If there are more URIs, we split on vertical bar and show the real URL instead of duplicated text. Otherwise display depends on the pref URLLinkText. Test plan: Create item with uri = A | B | C Create another item with uri = D Check the results on staff detail view (items table). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 99354 [details] [review] Bug 24697: Split items.uri on staff detail view If there are more URIs, we split on vertical bar and show the real URL instead of duplicated text. Otherwise display depends on the pref URLLinkText. Test plan: Create item with uri = A | B | C Create another item with uri = D Check the results on staff detail view (items table). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 99467 [details] [review] Bug 24697: Split items.uri on staff detail view If there are more URIs, we split on vertical bar and show the real URL instead of duplicated text. Otherwise display depends on the pref URLLinkText. Test plan: Create item with uri = A | B | C Create another item with uri = D Check the results on staff detail view (items table). Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described, no errors. (In reply to Bernardo Gonzalez Kriegel from comment #3) > Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > Works as described, no errors. Thx Bernardo Why do you split on | ? (In reply to Jonathan Druart from comment #5) > Why do you split on | ? It is the character used when gluing values in MARC to Koha. Created attachment 102932 [details] [review] Bug 24697: Split items.uri on staff detail view If there are more URIs, we split on vertical bar and show the real URL instead of duplicated text. Otherwise display depends on the pref URLLinkText. Test plan: Create item with uri = A | B | C Create another item with uri = D Check the results on staff detail view (items table). Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described, no errors. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Jonathan Druart from comment #7) > Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Thx (as always :) Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x |