Bug 24721

Summary: emailLibrarianWhenHoldIsPlaced should use Koha::Library->inbound_email_address
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: Architecture, internals, and plumbingAssignee: Martin Renvoize <martin.renvoize>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: 1joynelson, jonathan.druart, katrin.fischer
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05.00
Bug Depends on: 22823    
Bug Blocks:    
Attachments: Bug 24721: Update emailLibrarianWhenHoldIsPlaced to use effective_email
Bug 24721: Update emailLibrarianWhenHoldIsPlaced to use inbound_email_address
Bug 24721: Update emailLibrarianWhenHoldIsPlaced to use inbound_email_address

Description Martin Renvoize 2020-02-25 10:59:26 UTC
Bug 22823 introduced a consistent method for obtaining the inbound email address of a library branch, we should use that method to obtain the correct address for use with the emailLibrarianWhenHoldIsPlaced functionality.
Comment 1 Martin Renvoize 2020-02-25 11:05:39 UTC
Created attachment 99571 [details] [review]
Bug 24721: Update emailLibrarianWhenHoldIsPlaced to use effective_email

This patch updates the emailLibrarianWhenHoldIsPlaced functionality to
use the get_effective_email method to obtain the correct email address
for a branch.
Comment 2 Jonathan Druart 2020-03-18 09:52:36 UTC
Created attachment 100941 [details] [review]
Bug 24721: Update emailLibrarianWhenHoldIsPlaced to use inbound_email_address

This patch updates the emailLibrarianWhenHoldIsPlaced functionality to
use the inbound_email_address method to obtain the correct email address
for a branch.
Comment 3 Jonathan Druart 2020-03-18 09:52:59 UTC
The method has been renamed in a previous bug report.
Comment 4 Jonathan Druart 2020-03-18 10:22:43 UTC
Created attachment 100947 [details] [review]
Bug 24721: Update emailLibrarianWhenHoldIsPlaced to use inbound_email_address

This patch updates the emailLibrarianWhenHoldIsPlaced functionality to
use the inbound_email_address method to obtain the correct email address
for a branch.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Jonathan Druart 2020-03-18 10:24:06 UTC
Trivial patch, tested on top of the whole stack. Passing QA.
Comment 6 Martin Renvoize 2020-03-19 09:39:42 UTC
Nice work everyone!

Pushed to master for 20.05
Comment 7 Joy Nelson 2020-04-03 20:35:56 UTC
not backported due to dependencies