Summary: | EmailPurchaseSuggestions should use Koha::Library->inbound_email_address when set to 'BranchEmailAddress' | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Architecture, internals, and plumbing | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, jonathan.druart, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
Circulation function: | |||
Bug Depends on: | 22823 | ||
Bug Blocks: | |||
Attachments: |
Bug 24723: Update EmailPurchaseSuggestions to use effective_email
Bug 24723: Update EmailPurchaseSuggestions to use inbound_email_address Bug 24723: Update EmailPurchaseSuggestions to use inbound_email_address |
Description
Martin Renvoize (ashimema)
2020-02-25 11:13:08 UTC
Created attachment 99573 [details] [review] Bug 24723: Update EmailPurchaseSuggestions to use effective_email This patch updates the EmailPurchaseSuggestions functionality to use the get_effective_email method to obtain the correct email address for a branch when it is set to BranchEmail Created attachment 100942 [details] [review] Bug 24723: Update EmailPurchaseSuggestions to use inbound_email_address This patch updates the EmailPurchaseSuggestions functionality to use the inbound_email_address method to obtain the correct email address for a branch when it is set to BranchEmail The method has been renamed in a previous bug report. Created attachment 100948 [details] [review] Bug 24723: Update EmailPurchaseSuggestions to use inbound_email_address This patch updates the EmailPurchaseSuggestions functionality to use the inbound_email_address method to obtain the correct email address for a branch when it is set to BranchEmail Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Trivial patch, tested on top of the whole stack. Passing QA. Nice work everyone! Pushed to master for 20.05 not backported to 19.11.x due to dependencies |