Summary: | Cannot search for duplicate orders using 'Basket created by' field | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Acquisitions | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, hayleypelham, jonathan.druart, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.05, 19.05.10, 18.11.16
|
|
Circulation function: | |||
Bug Depends on: | 15184 | ||
Bug Blocks: | |||
Attachments: |
Bug 24733: created_by param should be an arrayref
Bug 24733: created_by param should be an arrayref |
Description
Nick Clemens (kidclamp)
2020-02-26 03:16:19 UTC
Created attachment 99628 [details] [review] Bug 24733: created_by param should be an arrayref We allow for the user to add multiple users to this field, and the search function expects and array. We have been treating it as a scalar TO test: 1 - Have an open basket in acquisitions 2 - Add to basket - from an existing order (copy) 3 - Enter a name in the 'Basket created by' field and select a user 4 - Hit search 5 - ISE (Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/share/koha/lib/C4/Acquisition.pm line 2482.) 6 - Apply patch 7 - Repeat 1-4 8 - Success! 9 - Test with mutiple 'created by' entries as well Created attachment 99630 [details] [review] Bug 24733: created_by param should be an arrayref We allow for the user to add multiple users to this field, and the search function expects and array. We have been treating it as a scalar TO test: 1 - Have an open basket in acquisitions 2 - Add to basket - from an existing order (copy) 3 - Enter a name in the 'Basket created by' field and select a user 4 - Hit search 5 - ISE (Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/share/koha/lib/C4/Acquisition.pm line 2482.) 6 - Apply patch 7 - Repeat 1-4 8 - Success! 9 - Test with mutiple 'created by' entries as well Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Oops, sorry about that! Trivial, marking as PQA. Nice work everyone! Pushed to master for 20.05 backported to 19.11.x for 19.11.05 backported to 19.05.x for 19.05.10 Backported to 18.11.x for 18.11.16 |