| Summary: | Duplicate id in opacheader markup | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | 1joynelson |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 22880 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 24746: Duplicate id in opacheader markup
Bug 24746: Duplicate id in opacheader markup Bug 24746: Duplicate id in opacheader markup Bug 24746: Duplicate id in opacheader markup Bug 24746: Duplicate id in opacheader markup Bug 24746: Duplicate id in opacheader markup |
||
|
Description
Owen Leonard
2020-02-27 17:30:16 UTC
Created attachment 99709 [details] [review] Bug 24746: Duplicate id in opacheader markup This patch removes '<div id="opacheader">' from masthead.inc because the same markup is generated by koha_news_block. To reproduce the bug, make sure there is an opacheader news block defined. Add this to the OPACUserCSS system preference: View the main page of the OPAC. You should see two blue borders around the opacheader content. Apply the patch and reload the OPAC page. There should now be only one blue border. Created attachment 99738 [details] [review] Bug 24746: Duplicate id in opacheader markup This patch removes '<div id="opacheader">' from masthead.inc because the same markup is generated by koha_news_block. To reproduce the bug, make sure there is an opacheader news block defined. Add this to the OPACUserCSS system preference: View the main page of the OPAC. You should see two blue borders around the opacheader content. Apply the patch and reload the OPAC page. There should now be only one blue border. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested whith OPACUserCSS -> #opacheader { border: 1px solid blue; padding: 1px; } don't know the intended value but works :) Work as described following test plan, no errors. I wonder if this could create issues for people who have tied markup etc. to the id without having the pref filled? Created attachment 99802 [details] [review] Bug 24746: Duplicate id in opacheader markup This patch removes '<div id="opacheader">' from masthead.inc because the same markup is generated by koha_news_block. To reproduce the bug, make sure there is an opacheader news block defined. Add this to the OPACUserCSS system preference: View the main page of the OPAC. You should see two blue borders around the opacheader content. Apply the patch and reload the OPAC page. There should now be only one blue border. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested whith OPACUserCSS -> #opacheader { border: 1px solid blue; padding: 1px; } don't know the intended value but works :) Work as described following test plan, no errors. Created attachment 99803 [details] [review] Bug 24746: Duplicate id in opacheader markup This patch removes '<div id="opacheader">' from masthead.inc because the same markup is generated by koha_news_block. To reproduce the bug, make sure there is an opacheader news block defined. Add this to the OPACUserCSS system preference: View the main page of the OPAC. You should see two blue borders around the opacheader content. Apply the patch and reload the OPAC page. There should now be only one blue border. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested whith OPACUserCSS -> #opacheader { border: 1px solid blue; padding: 1px; } don't know the intended value but works :) Work as described following test plan, no errors. Created attachment 99804 [details] [review] Bug 24746: Duplicate id in opacheader markup This patch removes '<div id="opacheader">' from masthead.inc because the same markup is generated by koha_news_block. To reproduce the bug, make sure there is an opacheader news block defined. Add this to the OPACUserCSS system preference: View the main page of the OPAC. You should see two blue borders around the opacheader content. Apply the patch and reload the OPAC page. There should now be only one blue border. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested whith OPACUserCSS -> #opacheader { border: 1px solid blue; padding: 1px; } don't know the intended value but works :) Work as described following test plan, no errors. Created attachment 99805 [details] [review] Bug 24746: Duplicate id in opacheader markup This patch removes '<div id="opacheader">' from masthead.inc because the same markup is generated by koha_news_block. To reproduce the bug, make sure there is an opacheader news block defined. Add this to the OPACUserCSS system preference: View the main page of the OPAC. You should see two blue borders around the opacheader content. Apply the patch and reload the OPAC page. There should now be only one blue border. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested whith OPACUserCSS -> #opacheader { border: 1px solid blue; padding: 1px; } don't know the intended value but works :) Work as described following test plan, no errors. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 not backported 19.11.x due to dependencies |