Summary: | Remove 'ITS' macro format | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Cataloging | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, carnold, hayleypelham, jonathan.druart, lucas, m.de.rooy, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
During the initial Rancor (advanced cataloging editor) development an existing macro language was copied. As development continued a Rancor macro language was developed. The new language accomplished all needs of the prior language. The old macro language was intended to be removed before submission to community, but was missed. These patches remove the legacy support in favour of the Koha specific model.
|
Version(s) released in: |
20.05.00, 19.11.05, 19.05.10
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 17268 | ||
Attachments: |
Bug 24789: Remove ITS macro format
Bug 24789: Remove ITS macro format Bug 24789: Remove ITS macro format Bug 24789: [follow-up] Fix saving of macros |
Description
Nick Clemens (kidclamp)
2020-03-03 13:30:05 UTC
Created attachment 100005 [details] [review] Bug 24789: Remove ITS macro format To test: 1 - Apply patches 2 - Confirm you can save, load, and run macros 3 - Confirm you have no choice of format Hmm, I think I thought the ITS format may be marginally more functional that our own so I wondered if rather than removal we should fully document it. Were there copyright issues that required it's removal perhaps.. if so I'd love to see any missing functionality added into our own macro format as part of a removal? Martin, In our (DGI's) experience, the ITS functionality in Koha isn't completely compatible with a macro exported out of ITS. In all cases I was able to create a Koha macro functionally the same as the ITS macro (albeit in multiple lines where the ITS version may have had 1). That's good to know Cori, sounds like we can indeed nuke it then. :) Created attachment 100578 [details] [review] Bug 24789: Remove ITS macro format To test: 1 - Apply patches 2 - Confirm you can save, load, and run macros 3 - Confirm you have no choice of format Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 100700 [details] [review] Bug 24789: Remove ITS macro format To test: 1 - Apply patches 2 - Confirm you can save, load, and run macros 3 - Confirm you have no choice of format Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Please update text to go into release notes for this one! Nice work everyone! Pushed to master for 20.05 Created attachment 100757 [details] [review] Bug 24789: [follow-up] Fix saving of macros Saving was accidentally commented out in patches, this restores that To test: 1 - Create a new macro 2 - Add some content 3 - Reload the macro, no content 4 - Apply patch 5 - Repeat 6 - Macro saves/loads correctly Nice work everyone! Pushed to master for 20.05 backported to 19.11.x branch for 19.11.05 backported to 19.05.x for 19.05.10 Enhancement/minor will not be backported to 18.11.x series |