Summary: | Untranslatable strings in results.js | ||
---|---|---|---|
Product: | Koha | Reporter: | paxed <pasi.kallinen> |
Component: | I18N/L10N | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | 1joynelson, bgkriegel, f.demians, jonathan.druart, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
Circulation function: | |||
Bug Depends on: | 23885 | ||
Bug Blocks: | |||
Attachments: |
Bug 24808: enable translation on results.js
Bug 24808: enable translation on results.js Bug 24808: enable translation on results.js |
Description
paxed
2020-03-05 10:50:29 UTC
Created attachment 103891 [details] [review] Bug 24808: enable translation on results.js String sorrounded by "__()" To test: 1) create translation files for a language (cd misc/translator; ./translate create xx-YY) 2) Check string egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 2 files, opac-bootstrap and staf-prog 3) Apply patch 4) Create files again (cd misc/translator; rm -f po/xx-YY*; ./translate create xx-YY) 5) Check again egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 3 files, new in messages-js Created attachment 103932 [details] [review] Bug 24808: enable translation on results.js String sorrounded by "__()" To test: 1) create translation files for a language (cd misc/translator; ./translate create xx-YY) 2) Check string egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 2 files, opac-bootstrap and staf-prog 3) Apply patch 4) Create files again (cd misc/translator; rm -f po/xx-YY*; ./translate create xx-YY) 5) Check again egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 3 files, new in messages-js Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 104141 [details] [review] Bug 24808: enable translation on results.js String sorrounded by "__()" To test: 1) create translation files for a language (cd misc/translator; ./translate create xx-YY) 2) Check string egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 2 files, opac-bootstrap and staf-prog 3) Apply patch 4) Create files again (cd misc/translator; rm -f po/xx-YY*; ./translate create xx-YY) 5) Check again egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 3 files, new in messages-js Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 koha-tmpl/intranet-tmpl/prog/js/pages/results.js does not exist in 19.11 patch not applicable to 19.11 not backported |