| Summary: | Add permission for 'discount' process | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Michal Denar <black23> |
| Component: | Fines and fees | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, black23, josef.moravec, martin.renvoize, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 24081 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 24812: (bug 24081 follow-up) Add permission description
Bug 24812: (bug 24081 follow-up) Add permission description Bug 24812: (bug 24081 follow-up) Add permission description |
||
|
Description
Michal Denar
2020-03-05 13:19:14 UTC
If staff can make discount from payment, we need to give permission for it. Because it's similar process as write-off. Did you test this Michal? The original patchset was meant to add such a permission.. Aha.. I see.. the UI piece for actually setting the permission got lost in a rebase! Patch coming. Created attachment 100197 [details] [review] Bug 24812: (bug 24081 follow-up) Add permission description Bug 24081 added a discount permission to the accounts system but during subsequent rebases, the description of that new permission got lot. This patch restores the description. Test plan 0/ Check that a checkbox without a description appears in the 'Manage patrons patrons fines and fees' section of the 'Set permissions' page. 1/ Apply the patch 2/ Reload the page and note that the checkbox now preceeds a suitable description. 3/ Signoff. Bonus points: Check the permission works as described and hides the 'Discount' action button for staff who do not have the permission enabled. Created attachment 100198 [details] [review] Bug 24812: (bug 24081 follow-up) Add permission description Bug 24081 added a discount permission to the accounts system but during subsequent rebases, the description of that new permission got lot. This patch restores the description. Test plan 0/ Check that a checkbox without a description appears in the 'Manage patrons patrons fines and fees' section of the 'Set permissions' page. 1/ Apply the patch 2/ Reload the page and note that the checkbox now preceeds a suitable description. 3/ Signoff. Bonus points: Check the permission works as described and hides the 'Discount' action button for staff who do not have the permission enabled. Nice work. Signed-off-by: Michal Denar <black23@gmail.com> Created attachment 100458 [details] [review] Bug 24812: (bug 24081 follow-up) Add permission description Bug 24081 added a discount permission to the accounts system but during subsequent rebases, the description of that new permission got lot. This patch restores the description. Test plan 0/ Check that a checkbox without a description appears in the 'Manage patrons patrons fines and fees' section of the 'Set permissions' page. 1/ Apply the patch 2/ Reload the page and note that the checkbox now preceeds a suitable description. 3/ Signoff. Bonus points: Check the permission works as described and hides the 'Discount' action button for staff who do not have the permission enabled. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 not pushed to 19.11.x due to dependencies |