*** Bug 14376 has been marked as a duplicate of this bug. *** Created attachment 100223 [details] [review] Bug 24819: Allow the librarian to choose a patron when entering a purchase suggestion Sometimes librarians are creating purchase suggestions that came from patrons which didn't use the opac (but sent an email, or told the librarian verbally...) This patch allows the librarian to change the creator of the purchase suggestion when entering it. This way, the patron will be able to receive notifications during the purchase suggestion workflow. Test plan: - Apply the patch - Check that you can change the default creator of the purchase suggestion when creating a new suggestion by clicking on 'Set to patron' (Home > Acquisitions > Suggestions management > New purchase suggestion) - Check that you can also change the creator of the purchase suggestion when editing an existing suggestion Created attachment 100281 [details] [review] Bug 24819: Allow the librarian to choose a patron when entering a purchase suggestion Sometimes librarians are creating purchase suggestions that came from patrons which didn't use the opac (but sent an email, or told the librarian verbally...) This patch allows the librarian to change the creator of the purchase suggestion when entering it. This way, the patron will be able to receive notifications during the purchase suggestion workflow. Test plan: - Apply the patch - Check that you can change the default creator of the purchase suggestion when creating a new suggestion by clicking on 'Set to patron' (Home > Acquisitions > Suggestions management > New purchase suggestion) - Check that you can also change the creator of the purchase suggestion when editing an existing suggestion Signed-off-by: Owen Leonard <oleonard@myacpl.org> Strange to call files suggestion_search.pl and suggestion_search.tt since its a patron search no ? Well, not that strange according to me: common/patron_search.tt is the basecode for patrons search If you look at what's existing: Since: guarantor_search.(pl||tt) using patron_search.tt => using patron search in a guarantor context Seems pretty consistent that: suggestion_search.(pl||tt) using patron_search.tt => using patron search in a suggestion context Don't you think? (In reply to Matthias Meusburger from comment #5) > Well, not that strange according to me: > > common/patron_search.tt is the basecode for patrons search > > If you look at what's existing: > > Since: > > guarantor_search.(pl||tt) using patron_search.tt > > => using patron search in a guarantor context > > > Seems pretty consistent that: > > suggestion_search.(pl||tt) using patron_search.tt > > => using patron search in a suggestion context > > > Don't you think? Ah i see. In my opinion : guarantor_search limits search to patrons that can be a garantor so its correct. In our case its simply patron search. Appears to work well and passes QA tools. I got a suggestion for the file naming: suggestor_search Would this work? I agree with Frido that suggestion_search is misleading and makes it sounds like a search for suggestions. Created attachment 101583 [details] [review] Bug 24819: (follow-up) Rename suggestion_search to suggestor_search When testing on sandbox : CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt Created attachment 101716 [details] [review] Bug 24819: Allow the librarian to choose a patron when entering a purchase suggestion Sometimes librarians are creating purchase suggestions that came from patrons which didn't use the opac (but sent an email, or told the librarian verbally...) This patch allows the librarian to change the creator of the purchase suggestion when entering it. This way, the patron will be able to receive notifications during the purchase suggestion workflow. Test plan: - Apply the patch - Check that you can change the default creator of the purchase suggestion when creating a new suggestion by clicking on 'Set to patron' (Home > Acquisitions > Suggestions management > New purchase suggestion) - Check that you can also change the creator of the purchase suggestion when editing an existing suggestion Signed-off-by: Owen Leonard <oleonard@myacpl.org> Rebased on master. Created attachment 101788 [details] [review] follow-up Created attachment 101789 [details] [review] Bug 24819: (follow-up) Rename suggestion_search to suggestor_search I re-uploaded the follow-up, patch order is now correct in Bugzilla, git bz applies the patches in the correct order. Created attachment 103197 [details] [review] Bug 24819: Allow the librarian to choose a patron when entering a purchase suggestion Sometimes librarians are creating purchase suggestions that came from patrons which didn't use the opac (but sent an email, or told the librarian verbally...) This patch allows the librarian to change the creator of the purchase suggestion when entering it. This way, the patron will be able to receive notifications during the purchase suggestion workflow. Test plan: - Apply the patch - Check that you can change the default creator of the purchase suggestion when creating a new suggestion by clicking on 'Set to patron' (Home > Acquisitions > Suggestions management > New purchase suggestion) - Check that you can also change the creator of the purchase suggestion when editing an existing suggestion Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 103198 [details] [review] Bug 24819: (follow-up) Rename suggestion_search to suggestor_search Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 103199 [details] [review] Bug 24819: (follow-up) Rename suggestor to suggester I believe I suggested a typo - trying to fix it here. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x |
Sometimes librarians are creating purchase suggestions that came from patrons which didn't use the opac (but sent an email, or told the librarian verbally...) This patch allows the librarian to change the creator of the purchase suggestion when entering it. This way, the patron will be able to receive notifications during the purchase suggestion workflow. Test plan: - Apply the patch - Check that you can change the default creator of the purchase suggestion when creating a new suggestion by clicking on 'Set to patron' (Home > Acquisitions > Suggestions management > New purchase suggestion) - Check that you can also change the creator of the purchase suggestion when editing an existing suggestion This is a rewrite of Bug 14376. Since it has been rewritten from scratch, I thought it would be cleaner to create a new Bug, but let me know otherwise. This rewrite now uses the common way to select a patron, as requested in Bug 14376.