Summary: | Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm | ||
---|---|---|---|
Product: | Koha | Reporter: | mjnkml |
Component: | Notices | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | 1joynelson, black23, dcook, faiz.ahmed, jonathan.druart, lucas, martin.renvoize, mjnkml |
Version: | Main | ||
Hardware: | All | ||
OS: | Linux | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.06, 19.05.11
|
|
Attachments: |
Bug 24826: Remove warnings from Sendmail
Bug 24826: Remove warnings from Sendmail |
Description
mjnkml
2020-03-08 06:58:12 UTC
Created attachment 100579 [details] [review] Bug 24826: Remove warnings from Sendmail Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm This is just a guess, I did not try this patch. Hi, are you able to test this patch? I do not have Sendmail configured in my test environment so cannot recreate the problem. (In reply to Jonathan Druart from comment #2) > Hi, are you able to test this patch? > > I do not have Sendmail configured in my test environment so cannot recreate > the problem. Hi, Just to clarify: I'm using postfix. The patch seems to work really well. Some output: before patching: $ sudo koha-foreach --chdir --enabled --email /usr/share/koha/bin/cronjobs/overdue_notices_borrower_1_only.pl -t $ sudo koha-foreach --chdir --enabled --email /usr/share/koha/bin/cronjobs/process_message_queue.pl -v sending email message to patron: 1 at /usr/share/koha/lib/C4/Letters.pm line 980. Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm line 253. Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm line 254. Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm line 544, <S> chunk 16. Use of uninitialized value $mail{"Cc"} in concatenation (.) or string at /usr/share/perl5/Mail/Sendmail.pm line 545, <S> chunk 16. sending email message to patron: 1 at /usr/share/koha/lib/C4/Letters.pm line 980. Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm line 253. Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm line 254. Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm line 544, <S> chunk 16. Use of uninitialized value $mail{"Cc"} in concatenation (.) or string at /usr/share/perl5/Mail/Sendmail.pm line 545, <S> chunk 16. $ after patching: $ sudo koha-foreach --chdir --enabled --email /usr/share/koha/bin/cronjobs/overdue_notices_borrower_1_only.pl -t $ sudo koha-foreach --chdir --enabled --email /usr/share/koha/bin/cronjobs/process_message_queue.pl -v sending email message to patron: 1 at /usr/share/koha/lib/C4/Letters.pm line 980. sending email message to patron: 1 at /usr/share/koha/lib/C4/Letters.pm line 980. $ Could you attach a signed-off patch? Created attachment 102534 [details] [review] Bug 24826: Remove warnings from Sendmail Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm This is just a guess, I did not try this patch. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Taking mjnkml@gmail.com as the SO and passing QA as this is a trivial and clear fix. Nice work everyone! Pushed to master for 20.05 backported to 19.11.x for 19.11.06 backported to 19.05.x for 19.05.11 *** Bug 27084 has been marked as a duplicate of this bug. *** *** Bug 27084 has been marked as a duplicate of this bug. *** |