Summary: | ClaimReturnedWarningThreshold is always triggered if patron has one or more claims | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Circulation | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | 1joynelson, gmcharlt, hc, kyle.m.hall, sally.healey |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.05
|
|
Circulation function: | |||
Attachments: |
Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims
Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims |
Description
Kyle M Hall (khall)
2020-03-09 13:33:48 UTC
Created attachment 100375 [details] [review] Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims ClaimReturnedWarningThreshold is supposed to display a warning if a patron has more than the number of claims specified in the system preference. Currently the warning is displayed for any number of claims over zero. Test Plan: 1) Make 3 return claims for a patron 2) Set ClaimReturnedWarningThreshold to 4 3) Note the claims warning displays for the patron on circulation.pl 4) Apply this patch 5) Reload circulation.pl, the warning should go away 6) Set ClaimReturnedWarningThreshold to 2 7) Reload the page, the warning should reappear Created attachment 101582 [details] [review] Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims ClaimReturnedWarningThreshold is supposed to display a warning if a patron has more than the number of claims specified in the system preference. Currently the warning is displayed for any number of claims over zero. Test Plan: 1) Make 3 return claims for a patron 2) Set ClaimReturnedWarningThreshold to 4 3) Note the claims warning displays for the patron on circulation.pl 4) Apply this patch 5) Reload circulation.pl, the warning should go away 6) Set ClaimReturnedWarningThreshold to 2 7) Reload the page, the warning should reappear Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 101779 [details] [review] Bug 24829: ClaimReturnedWarningThreshold is always triggered if patron has one or more claims ClaimReturnedWarningThreshold is supposed to display a warning if a patron has more than the number of claims specified in the system preference. Currently the warning is displayed for any number of claims over zero. Test Plan: 1) Make 3 return claims for a patron 2) Set ClaimReturnedWarningThreshold to 4 3) Note the claims warning displays for the patron on circulation.pl 4) Apply this patch 5) Reload circulation.pl, the warning should go away 6) Set ClaimReturnedWarningThreshold to 2 7) Reload the page, the warning should reappear Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 backported to 19.11.x for 19.11.05 |