|
Description
Jonathan Druart
2020-03-11 16:29:02 UTC
Created attachment 100590 [details] [review] Bug 24851: Insert libraries sample data for "UNIMARC" I am trying to make koha-testing-docker UNIMARC compabible. In order to have koha-misc4dev insert all the data correctly (users, etc.) we need at least 1 library. I am suggesting to reuse the usual library list for UNIMARC. misc4dev will use fr-FR sample data for "UNIMARC" This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29 Test plan: outside your box, in koha-testing-docker (up-to-date), edit .env and set KOHA_MARC_FLAVOUR=unimarc DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc Then start the koha container When the misc4dev will start its job, the scripts will have the expected data to continue. Without this patch you will get koha_1 | Not enough data in the database, library and/or patron category does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31. And plenty of errors will follow. Also, the sample data used in misc4dev will use CPL (/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql) Created attachment 100596 [details] [review] Bug 24851: Insert libraries sample data for "UNIMARC" I am trying to make koha-testing-docker UNIMARC compabible. In order to have koha-misc4dev insert all the data correctly (users, etc.) we need at least 1 library. I am suggesting to reuse the usual library list for UNIMARC. misc4dev will use fr-FR sample data for "UNIMARC" This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29 Test plan: outside your box, in koha-testing-docker (up-to-date), edit .env and set KOHA_MARC_FLAVOUR=unimarc DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc Then start the koha container When the misc4dev will start its job, the scripts will have the expected data to continue. Without this patch you will get koha_1 | Not enough data in the database, library and/or patron category does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31. And plenty of errors will follow. Also, the sample data used in misc4dev will use CPL (/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql) Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Thanks Jonathan for doing this, and Jon for testing. It will be great to be able to test UNIMARC related bugs using koha-testing-docker! I was trying to test this earlier, and I couldn't get it to work by following the test plan - so I'm probably doing something wrong! What I did and the results: 1) git pull for the koha-testing-docker repository (so that is up-to-date) and docker-compose pull so that all the images are up-to-date as well. 2) Started up, kshell, applied patch, shut down 3) Made the changes to the .env file 4) Started up koha-testing-docker 5) Get these messages during start up: Not enough data in the database, library and/or patron category does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31. ... ... C4::Installer::load_sql returned the following errors while attempting to load /kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql: koha_1 | DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at /usr/share/perl5/DBIx/RunSQL.pm line 273. koha_1 | Something went wrong loading file /kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql ([SQL ERROR]: INSERT INTO `items` ( `itemn... ..... ..... error retrieving biblio 1 at /kohadevbox/koha/misc/migration_tools/rebuild_zebra.pl line 681. ^^^^ that message repeats - trying to retrieve all the biblio entries (number after changes) Use of uninitialized value in string eq at /kohadevbox/koha/misc/migration_tools/rebuild_zebra.pl line 663. ^^^^ line number changes between 86, 92, and 663 6) When I go to 127.0.0.1:8081 I get the web installer Not sure what I'm doing wrong here, but I'm sure it is something simple and obvious to you! The patch is applied, so I shouldn't be getting all the errors above! Yes David, that's exactly the purpose of this patch here :) I have just done a pull request on koha-misc4dev: https://gitlab.com/koha-community/koha-misc4dev/-/issues/29 Could you retry using the test plan I let on the pull request? What you tried should have worked. Thanks Jonathan! I'll have another go at it this evening. Created attachment 100691 [details] Bug 24851: UNIMARC - koha-testing-docker start up I had another go. Bug 24851 and Bug 24856 seem to have applied successfully, and it seems to have picked up the changes from https://gitlab.com/joubu/koha-misc4dev/-/tree/issue_29 I've attached the log of the koha-testing-docker start up - I've removed the repeating error lines at 14346 and 14385, and the insertion of reocords and authorities. End result for me = web installer appears when you go to 127.0.0.1:8081 I'll let someone else have a go - they may be more successful in getting this working! Only one thing here: +++ b/installer/data/mysql/fr-FR/2-Optionel/sample_libraries.txt I think this should be in French! Created attachment 100736 [details] [review] Bug 24851: Translate the .txt in French Created attachment 100818 [details] [review] Bug 24851: Insert libraries sample data for "UNIMARC" I am trying to make koha-testing-docker UNIMARC compabible. In order to have koha-misc4dev insert all the data correctly (users, etc.) we need at least 1 library. I am suggesting to reuse the usual library list for UNIMARC. misc4dev will use fr-FR sample data for "UNIMARC" This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29 Test plan: outside your box, in koha-testing-docker (up-to-date), edit .env and set KOHA_MARC_FLAVOUR=unimarc DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc Then start the koha container When the misc4dev will start its job, the scripts will have the expected data to continue. Without this patch you will get koha_1 | Not enough data in the database, library and/or patron category does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31. And plenty of errors will follow. Also, the sample data used in misc4dev will use CPL (/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql) Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 100819 [details] [review] Bug 24851: Insert libraries sample data for "UNIMARC" I am trying to make koha-testing-docker UNIMARC compabible. In order to have koha-misc4dev insert all the data correctly (users, etc.) we need at least 1 library. I am suggesting to reuse the usual library list for UNIMARC. misc4dev will use fr-FR sample data for "UNIMARC" This is related to https://gitlab.com/koha-community/koha-misc4dev/issues/29 Test plan: outside your box, in koha-testing-docker (up-to-date), edit .env and set KOHA_MARC_FLAVOUR=unimarc DEBUG_GIT_REPO_MISC4DEV_URL=https://gitlab.com/joubu/koha-misc4dev.git DEBUG_GIT_REPO_MISC4DEV_BRANCH=unimarc Then start the koha container When the misc4dev will start its job, the scripts will have the expected data to continue. Without this patch you will get koha_1 | Not enough data in the database, library and/or patron category does not exist at /kohadevbox/misc4dev/create_superlibrarian.pl line 31. And plenty of errors will follow. Also, the sample data used in misc4dev will use CPL (/kohadevbox/misc4dev/data/sql/unimarc/1812/after_22155/items.sql) Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Current status: Passed QA Created attachment 100820 [details] [review] Bug 24851: Translate the .txt in French Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 backported to 19.11.x branch for 19.11.05 backported to 19.05.x for 19.05.10 Enhancement/normal will not be backported to 18.11.x series |