Summary: | Remove IDreamBooks integration | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, dcook, jonathan.druart, nick, tgoatley, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.05.00, 19.11.06, 19.05.12
|
Circulation function: | |
Attachments: |
Bug 24854: Remove IDreamBooks integration
Bug 24854: Remove IDreamBooks integration Bug 24854: Remove IDreamBooks integration Bug 24854: Remove IDreamBooks integration Bug 24854: Remove IDreamBooks integration [19.11.X] Bug 24854: Disable IDreamBooks sysprefs |
Description
Owen Leonard
2020-03-11 18:22:56 UTC
Last blog entries are from 7 years ago - can't see an official statement, but it looks very dead. Created attachment 100713 [details] [review] Bug 24854: Remove IDreamBooks integration The IDreamBooks service has not seen updates in a long time, so we should remove the service from Koha as it's no longer operational. To test: - Apply patch and run the database update - Verify that the IDreamBooks related system preferences are gone - Verify that opac detail pages and result lists still work as expected - Run t/db_dependent/UsageStats.t Created attachment 100833 [details] [review] Bug 24854: Remove IDreamBooks integration The IDreamBooks service has not seen updates in a long time, so we should remove the service from Koha as it's no longer operational. To test: - Apply patch and run the database update - Verify that the IDreamBooks related system preferences are gone - Verify that opac detail pages and result lists still work as expected - Run t/db_dependent/UsageStats.t Created attachment 100835 [details] [review] Bug 24854: Remove IDreamBooks integration The IDreamBooks service has not seen updates in a long time, so we should remove the service from Koha as it's no longer operational. To test: - Apply patch and run the database update - Verify that the IDreamBooks related system preferences are gone - Verify that opac detail pages and result lists still work as expected - Run t/db_dependent/UsageStats.t Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Thx Lucas! Can this be set to signed off? Created attachment 101338 [details] [review] Bug 24854: Remove IDreamBooks integration The IDreamBooks service has not seen updates in a long time, so we should remove the service from Koha as it's no longer operational. To test: - Apply patch and run the database update - Verify that the IDreamBooks related system preferences are gone - Verify that opac detail pages and result lists still work as expected - Run t/db_dependent/UsageStats.t Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Prefs gone. Fixed missing 'r' in atomic update message. Test pass, no errors. Created attachment 101489 [details] [review] Bug 24854: Remove IDreamBooks integration The IDreamBooks service has not seen updates in a long time, so we should remove the service from Koha as it's no longer operational. To test: - Apply patch and run the database update - Verify that the IDreamBooks related system preferences are gone - Verify that opac detail pages and result lists still work as expected - Run t/db_dependent/UsageStats.t Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Prefs gone. Fixed missing 'r' in atomic update message. Test pass, no errors. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work everyone! Pushed to master for 20.05 not backported to 19.11.x *** Bug 25496 has been marked as a duplicate of this bug. *** (In reply to Joy Nelson from comment #9) > not backported to 19.11.x Joy, regarding bug 25496 maybe we should remove it from stable branches as well. This doesn't apply nicely to 19.11.x branch. I wasn't comfortable with my rebasing in opac-detail.tt. If this is necessary for the maintenance branches, I'll need assistance with a rebase. Maybe we should just turn it off and display a message during the upgrade process? (In reply to Jonathan Druart from comment #13) > Maybe we should just turn it off and display a message during the upgrade > process? That sounds like a good idea for the older versions. Created attachment 105145 [details] [review] [19.11.X] Bug 24854: Disable IDreamBooks sysprefs Thanks for the rebase - pushed to 19.11.x for 19.11.06 (In reply to Joy Nelson from comment #16) > Thanks for the rebase - pushed to 19.11.x for 19.11.06 I should note that it's not really a rebase: the patch for 19.11 is only adding a DB update entry to disable the sysprefs. (In reply to Jonathan Druart from comment #17) > (In reply to Joy Nelson from comment #16) > > Thanks for the rebase - pushed to 19.11.x for 19.11.06 > > I should note that it's not really a rebase: the patch for 19.11 is only > adding a DB update entry to disable the sysprefs. heh- i noticed that! Nick mentioned I do the same as you did, but I thought y'all might want to remove all the related code as well. :D Removing the sysprefs is pretty effective I'd say! Thanks joy Backported to 19.05.x branch for 19.05.12 |