Summary: | Incorrect labels on wording in ExcludeHolidaysFromMaxPickUpDelay system preference | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
Component: | Staff interface | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | 1joynelson, gmcharlt, hayleypelham, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.05
|
|
Circulation function: | |||
Bug Depends on: | 22381 | ||
Bug Blocks: | 25779 | ||
Attachments: |
Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay
Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay |
Description
Andrew Fuerste-Henry
2020-03-12 13:48:56 UTC
Created attachment 100667 [details] [review] Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay TO TEST: - Apply patch - mark your library closed today and tomorrow - set ReservesMaxPickUpDelay to 1 day - set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar" - place hold, capture hold - hold expiration date is set to tomorrow (doesn't skip closed days) - Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar" - Place hold, capture hold - hold expiration date is set to the day after tomorrow (skips closed days) Created attachment 100669 [details] [review] Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay TO TEST: - Apply patch - mark your library closed today and tomorrow - set ReservesMaxPickUpDelay to 1 day - set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar" - place hold, capture hold - hold expiration date is set to tomorrow (doesn't skip closed days) - Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar" - Place hold, capture hold - hold expiration date is set to the day after tomorrow (skips closed days) Signed-off-by: David Nind <david@davidnind.com> Created attachment 100676 [details] [review] Bug 24858: Correct labels on wording in ExcludeHolidaysFromMaxPickUpDelay TO TEST: - Apply patch - mark your library closed today and tomorrow - set ReservesMaxPickUpDelay to 1 day - set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar" - place hold, capture hold - hold expiration date is set to tomorrow (doesn't skip closed days) - Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar" - Place hold, capture hold - hold expiration date is set to the day after tomorrow (skips closed days) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Thanks! Nice work everyone! Pushed to master for 20.05 Backported to 19.11.x branch for 19.11.05 backported to 19.05.x for 19.05.10 Dependency not in 18.11.x, not backporting to 18.11.x series reverted from 19.05.x, missing dependency that I overlooked |