Description
Marcel de Rooy
2020-03-19 10:47:30 UTC
Created attachment 101024 [details] [review] Bug 24903: Special characters like parentheses in numbering pattern cause duplication in recievedlist Test plan: Use serial with a numbering pattern with parentheses like "2018 (No. 1)". Mark serial issue as arrived, check receivedlist on summary. Edit issue again, check if not duplicated on receivedlist. Mark issue as missing or not available, check missinglist. Mark missing issue as not missing, check list again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 101025 [details] [review] Bug 24903: Add tests for _handle_seqno Trivial tests. Test plan: Run t/Serials/ModSerialStatus.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Patch tested with a sandbox, by Laurence Rault <laurence.rault@biblibre.com> Created attachment 102686 [details] [review] Bug 24903: Special characters like parentheses in numbering pattern cause duplication in recievedlist Test plan: Use serial with a numbering pattern with parentheses like "2018 (No. 1)". Mark serial issue as arrived, check receivedlist on summary. Edit issue again, check if not duplicated on receivedlist. Mark issue as missing or not available, check missinglist. Mark missing issue as not missing, check list again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Created attachment 102687 [details] [review] Bug 24903: Add tests for _handle_seqno Trivial tests. Test plan: Run t/Serials/ModSerialStatus.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> (In reply to sandboxes@biblibre.com from comment #5) > Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Thanks Laurence ! Created attachment 102776 [details] [review] Bug 24903: Special characters like parentheses in numbering pattern cause duplication in recievedlist Test plan: Use serial with a numbering pattern with parentheses like "2018 (No. 1)". Mark serial issue as arrived, check receivedlist on summary. Edit issue again, check if not duplicated on receivedlist. Mark issue as missing or not available, check missinglist. Mark missing issue as not missing, check list again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 102777 [details] [review] Bug 24903: Add tests for _handle_seqno Trivial tests. Test plan: Run t/Serials/ModSerialStatus.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Maybe an edge case: My number (18) was Arrived and listed as received. Change the status to missing. It's now both missing and received in the summary. Should to not be removed from the received list in this case? Marcel, I will let you judge if this should go on y separate bug report. Please also check bug 24842 for how it relates to this bug. Nice work everyone! Pushed to master for 20.05 backported to 19.11.x for 19.11.06 backported to 19.05.x for 19.05.11 *** Bug 24842 has been marked as a duplicate of this bug. *** This is not the correct way to handle "special characters" in regex, you must surround the $var with \Q \E instead. |