Summary: | Optionally exclude suspended holds from holds ratio report | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens <nick> |
Component: | Hold requests | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, gmcharlt, katrin.fischer |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
Bug Depends on: | |||
Bug Blocks: | 24953 | ||
Attachments: |
Bug 24907: Add 'include suspended' to holds ratio report
Bug 24907: Add 'include suspended' to holds ratio report Bug 24907: Add 'include suspended' to holds ratio report |
Description
Nick Clemens
2020-03-19 13:31:18 UTC
Created attachment 101016 [details] [review] Bug 24907: Add 'include suspended' to holds ratio report Some libraries would like the option to ignore suspended holds when using the holds ratio report Note: this report fails with strict mode enabled, please disable to test To test: 1 - Add enough holds to a record (3) to make it show on the holds ration report 2 - Browse to Circulation->Holds ratio 3 - Run with default settings and confirm the title shows up 4 - Suspend one of the holds 5 - Run report again and confirm title still shows 6 - Apply patch 7 - Reload the report 8 - Note new option 9 - Run report - title does not show 10 - Lower ratio to 2 and confirm the hold shows Created attachment 101062 [details] [review] Bug 24907: Add 'include suspended' to holds ratio report Some libraries would like the option to ignore suspended holds when using the holds ratio report Note: this report fails with strict mode enabled, please disable to test To test: 1 - Add enough holds to a record (3) to make it show on the holds ration report 2 - Browse to Circulation->Holds ratio 3 - Run with default settings and confirm the title shows up 4 - Suspend one of the holds 5 - Run report again and confirm title still shows 6 - Apply patch 7 - Reload the report 8 - Note new option 9 - Run report - title does not show 10 - Lower ratio to 2 and confirm the hold shows Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 101362 [details] [review] Bug 24907: Add 'include suspended' to holds ratio report Some libraries would like the option to ignore suspended holds when using the holds ratio report Note: this report fails with strict mode enabled, please disable to test To test: 1 - Add enough holds to a record (3) to make it show on the holds ration report 2 - Browse to Circulation->Holds ratio 3 - Run with default settings and confirm the title shows up 4 - Suspend one of the holds 5 - Run report again and confirm title still shows 6 - Apply patch 7 - Reload the report 8 - Note new option 9 - Run report - title does not show 10 - Lower ratio to 2 and confirm the hold shows Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> This follows the existing pattern so I think a slight behaviour change is ok in that case (default is now to exclude suspended holds). Wondering if on a separate report we could reformat the checkboxes: [checkbox] Text And maybe: Include instead of included? Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x |