Summary: | Exception holidays treated as unique holidays in calendar | ||
---|---|---|---|
Product: | Koha | Reporter: | Emmi Takkinen <emmi.takkinen> |
Component: | Holidays | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | ||
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: |
Description
Emmi Takkinen
2020-03-20 10:08:30 UTC
Just to make clear, this only happens if exception is made for unique holidays. Exceptions for holidays repeating weekly and yearly work properly. And now when I looked closer, hint for option "Generate exceptions on a range of dates" says "You can make an exception on a range of dates repeated yearly." and there isn't option to make single exception for unique holidays like there is with repeatable holidays. So... there shouldn't even be option to add exceptions for unique holidays? How should this be handled, make exceptions work properly with unique holidays or hide option "Generate exceptions on a range of dates" if holiday is unique? Ok, did some digging and I might have answered to my question myself. Patch with an option to generate exceptions on range for unique holidays was introduced in bug 7351. So it is where it should be, text in the hint just confused me. Sorry about this monologue. Hm, I think there is no point to have an exception for a unique holiday = you could just delete it. So maybe we should not allow exceptions in that case and suggest to remove from the calendar instead? (In reply to Katrin Fischer from comment #3) > Hm, I think there is no point to have an exception for a unique holiday = > you could just delete it. So maybe we should not allow exceptions in that > case and suggest to remove from the calendar instead? I agree. So we could just hide the option to generate exception when selected holiday is unique. Also seems like this was already reported in bug 9918. (In reply to Emmi Takkinen from comment #4) > (In reply to Katrin Fischer from comment #3) > > Hm, I think there is no point to have an exception for a unique holiday = > > you could just delete it. So maybe we should not allow exceptions in that > > case and suggest to remove from the calendar instead? > > I agree. So we could just hide the option to generate exception when > selected holiday is unique. Also seems like this was already reported in bug > 9918. Wrong bug, meant bug 9118. It's somewhat same as this one, maybe some cleanup is in order for all options... |