|
Description
Liz Rea
2020-03-26 15:20:45 UTC
Created attachment 101876 [details] [review] Bug 24993: add a pause between stopping and starting sip on restart To test: - have SIP enabled and running - issue a restart, make sure it restarts. sudo koha-sip --restart inst Created attachment 102255 [details] [review] Bug 24993: add a pause between stopping and starting sip on restart To test: - have SIP enabled and running - issue a restart, make sure it restarts. sudo koha-sip --restart inst Signed-off-by: David Nind <david@davidnind.com> Created attachment 102280 [details] [review] [ALTERNATIVE-PATCH] Bug 24993: Make sure SIP server is stopped before restarting it Hi Liz, what about this patch? I think "sleeping 3" is too arbitrary. We may need to add a max number of iterations to avoid looping forever (in case something went wrong). I don't know that I have an opinion about this, if you think your way is better I'll sign off on that. I do like the idea of a limit, if we have to do it this way. Created attachment 102546 [details] [review] Bug 24993: Make sure we are not going to loop indefinitely Hi Jonathan, I just tested this in my devbox, I'd get into the loop but every test I did, sip didn't get started after it stopped. I'll try to troubleshoot it but if you can immediately see what's wrong, happy for a fix. Cheers, Liz Created attachment 102648 [details] [review] Bug 24993: fix increment Aparently ((i++)) isn't portable, changed for an admittedly uglier but functional increment. Created attachment 102682 [details] [review] Bug 24993: fix increment Aparently ((i++)) isn't portable, changed for an admittedly uglier but functional increment. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 102752 [details] [review] Attachment to Bug 24993 - koha-sip --restart is too fast, doesn't always start sip Bug 24993: Make sure SIP server is stopped before restarting it Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 102753 [details] [review] Attachment to Bug 24993 - koha-sip --restart is too fast, doesn't always start sip Bug 24993: Make sure SIP server is stopped before restarting it Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 102754 [details] [review] Bug 24993: Make sure SIP server is stopped before restarting it Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 102755 [details] [review] Bug 24993: Make sure we are not going to loop indefinitely Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 102756 [details] [review] Bug 24993: fix increment Aparently ((i++)) isn't portable, changed for an admittedly uglier but functional increment. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Liz Rea <wizzyrea@gmail.com> The latest iteration of these patches is missing test plans and descriptions? Can you remind me where I need to copy the files for testing with kohadevbox? The test plan is the same as the original one. You need to restart the SIP server using koha-sip --restart, and makes sure is has been restarted (without this patch, it does not always). you can `reset_all` (which will call cp_debian_files.pl from misc4dev), or simply copy it to /usr/sbin/koha-sip (`which koha-sip` helps you to find it). (In reply to Jonathan Druart from comment #17) > The test plan is the same as the original one. I was referring to the fact, that there is nothing in the commit messages now, also it seems to have been there in early iterations? I'll readd it, but it's extra work I'd like to avoid :) > You need to restart the SIP server using koha-sip --restart, and makes sure > is has been restarted (without this patch, it does not always). > > you can `reset_all` (which will call cp_debian_files.pl from misc4dev), or > simply copy it to /usr/sbin/koha-sip (`which koha-sip` helps you to find it). Thx, exactly what I needed to know! Created attachment 102823 [details] [review] Bug 24993: Make sure SIP server is stopped before restarting it Sometimes doing koha-sip --restart instance happens too fast and the SIP server is not started. To test: - have SIP enabled and running for your instance - issue a restart, make sure it restarts sudo koha-sip --restart inst Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 102824 [details] [review] Bug 24993: Make sure we are not going to loop indefinitely Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 102825 [details] [review] Bug 24993: fix increment Aparently ((i++)) isn't portable, changed for an admittedly uglier but functional increment. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 backported to 19.11.x for 19.11.06 backported to 19.05.x for 19.05.11 |