|
Description
Andrew Fuerste-Henry
2020-04-07 19:17:31 UTC
This report gets that data one might want. It's not a pretty or fun report: SELECT borrowernumber, surname, firstname, club_id, clubs.name, club_template_enrollment_fields.name, club_enrollment_fields.value FROM club_enrollment_fields LEFT JOIN club_enrollments on (club_enrollment_fields.club_enrollment_id=club_enrollments.id) LEFT JOIN borrowers using (borrowernumber) LEFT JOIN clubs on (club_enrollments.club_id=clubs.id) LEFT JOIN club_template_enrollment_fields on (club_enrollment_fields.club_template_enrollment_field_id=club_template_enrollment_fields.id) WHERE clubs.id=<<Club ID>> and club_enrollments.date_canceled is null Created attachment 149544 [details] [review] Bug 25079: Add a 'edit' functionality to the Clubs tool in the staff interface A club enrollment can be cancel but it can't be edited This patch add a 'edit' functionality to the Clubs tool in the staff interface Test plan 1. Create a club template 1.1. Go to Tools > Patron clubs 1.2. Click on 'New Club Template' 1.3. Fill the form 1.4. on the 'Club fields' section, Click on Add new field 1.5. Fill in the form 1.6. on the 'Enrollment fields' section, Click on Add new field 1.7. Fill in the form 1.8. Click on Save button 2. Creation of the club 2.1. Go to Tools > Patron clubs > 'Clubs' section (bottom) 2.2. Click on the 'New Club' button and select the club template create on step 1 2.3. Fill in the form 2.4. Click on Save button 3. Club enrollement On the intranet 3.1. Search for a pratron and open the patron folder 3.2. Click on the 'Clubs' tab 3.3. Find the name of the club and click on 'Enroll' 3.4. Fill the questionnaire 3.5. Confirm registration ---> Note that the enrollement can be canceled but it cannot be modified 4. Apply the patch 5. Click one more time on the 'Clubs' tab ---> Note that the enrollement can now be modified Created attachment 149545 [details] [review] Bug 25079: Show club enrollment question answers in staff client When a patron is enrolled in a patron club, koha collects answers to library-defined enrollment questions. Those answers go into the database but are not viewable outside of reports. This patch make those answers viewable on club-enrollments.pl. Test plan 1. Apply the patch 2. Create a club template 2.1. Go to Tools > Patron clubs 2.2. Click on 'New Club Template' 2.3. Fill the form 2.4. on the 'Club fields' section, Click on Add new field 2.5. Fill in the form 2.6. on the 'Enrollment fields' section, Click on Add new field 2.7. Fill in the form 2.8. Click on Save button 3. Creation of the club 3.1. Go to Tools > Patron clubs > 'Clubs' section (bottom) 3.2. Click on the 'New Club' button and select the club template create on step 1 3.3. Fill in the form 3.4. Click on Save button 4. Club enrollement On the intranet (or the OPAC if permitted) 4.1. Search for a pratron and open the patron folder 4.2. Click on the 'Clubs' tab 4.3. Find the name of the club and click on 'Enroll' 4.4. Fill the questionnaire 4.5. Confirm registration 5. Check registrations on the intranet 5.1. Go to Tools > Patron clubs 5.2. In the bottom 'Clubs' section, find the name of the club 5.3. check the 'Enrolled patrons' column ---> should not be equal to zero. 5.4 Click on 'Action' and choose the option “Enrollments” ---> The Enrollment fields created on step 2.6. are viewable in the table with their values Created attachment 151603 [details] [review] Bug 25079: Add a 'edit' functionality to the Clubs tool in the staff interface A club enrollment can be cancel but it can't be edited This patch add a 'edit' functionality to the Clubs tool in the staff interface Test plan 1. Create a club template 1.1. Go to Tools > Patron clubs 1.2. Click on 'New Club Template' 1.3. Fill the form 1.4. on the 'Club fields' section, Click on Add new field 1.5. Fill in the form 1.6. on the 'Enrollment fields' section, Click on Add new field 1.7. Fill in the form 1.8. Click on Save button 2. Creation of the club 2.1. Go to Tools > Patron clubs > 'Clubs' section (bottom) 2.2. Click on the 'New Club' button and select the club template create on step 1 2.3. Fill in the form 2.4. Click on Save button 3. Club enrollement On the intranet 3.1. Search for a pratron and open the patron folder 3.2. Click on the 'Clubs' tab 3.3. Find the name of the club and click on 'Enroll' 3.4. Fill the questionnaire 3.5. Confirm registration ---> Note that the enrollement can be canceled but it cannot be modified 4. Apply the patch 5. Click one more time on the 'Clubs' tab ---> Note that the enrollement can now be modified Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 151604 [details] [review] Bug 25079: Show club enrollment question answers in staff client When a patron is enrolled in a patron club, koha collects answers to library-defined enrollment questions. Those answers go into the database but are not viewable outside of reports. This patch make those answers viewable on club-enrollments.pl. Test plan 1. Apply the patch 2. Create a club template 2.1. Go to Tools > Patron clubs 2.2. Click on 'New Club Template' 2.3. Fill the form 2.4. on the 'Club fields' section, Click on Add new field 2.5. Fill in the form 2.6. on the 'Enrollment fields' section, Click on Add new field 2.7. Fill in the form 2.8. Click on Save button 3. Creation of the club 3.1. Go to Tools > Patron clubs > 'Clubs' section (bottom) 3.2. Click on the 'New Club' button and select the club template create on step 1 3.3. Fill in the form 3.4. Click on Save button 4. Club enrollement On the intranet (or the OPAC if permitted) 4.1. Search for a pratron and open the patron folder 4.2. Click on the 'Clubs' tab 4.3. Find the name of the club and click on 'Enroll' 4.4. Fill the questionnaire 4.5. Confirm registration 5. Check registrations on the intranet 5.1. Go to Tools > Patron clubs 5.2. In the bottom 'Clubs' section, find the name of the club 5.3. check the 'Enrolled patrons' column ---> should not be equal to zero. 5.4 Click on 'Action' and choose the option “Enrollments” ---> The Enrollment fields created on step 2.6. are viewable in the table with their values Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 151818 [details] [review] Bug 25079: Add a 'edit' functionality to the Clubs tool in the staff interface A club enrollment can be cancel but it can't be edited This patch add a 'edit' functionality to the Clubs tool in the staff interface Test plan 1. Create a club template 1.1. Go to Tools > Patron clubs 1.2. Click on 'New Club Template' 1.3. Fill the form 1.4. on the 'Club fields' section, Click on Add new field 1.5. Fill in the form 1.6. on the 'Enrollment fields' section, Click on Add new field 1.7. Fill in the form 1.8. Click on Save button 2. Creation of the club 2.1. Go to Tools > Patron clubs > 'Clubs' section (bottom) 2.2. Click on the 'New Club' button and select the club template create on step 1 2.3. Fill in the form 2.4. Click on Save button 3. Club enrollement On the intranet 3.1. Search for a pratron and open the patron folder 3.2. Click on the 'Clubs' tab 3.3. Find the name of the club and click on 'Enroll' 3.4. Fill the questionnaire 3.5. Confirm registration ---> Note that the enrollement can be canceled but it cannot be modified 4. Apply the patch 5. Click one more time on the 'Clubs' tab ---> Note that the enrollement can now be modified Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 151819 [details] [review] Bug 25079: Show club enrollment question answers in staff client When a patron is enrolled in a patron club, koha collects answers to library-defined enrollment questions. Those answers go into the database but are not viewable outside of reports. This patch make those answers viewable on club-enrollments.pl. Test plan 1. Apply the patch 2. Create a club template 2.1. Go to Tools > Patron clubs 2.2. Click on 'New Club Template' 2.3. Fill the form 2.4. on the 'Club fields' section, Click on Add new field 2.5. Fill in the form 2.6. on the 'Enrollment fields' section, Click on Add new field 2.7. Fill in the form 2.8. Click on Save button 3. Creation of the club 3.1. Go to Tools > Patron clubs > 'Clubs' section (bottom) 3.2. Click on the 'New Club' button and select the club template create on step 1 3.3. Fill in the form 3.4. Click on Save button 4. Club enrollement On the intranet (or the OPAC if permitted) 4.1. Search for a pratron and open the patron folder 4.2. Click on the 'Clubs' tab 4.3. Find the name of the club and click on 'Enroll' 4.4. Fill the questionnaire 4.5. Confirm registration 5. Check registrations on the intranet 5.1. Go to Tools > Patron clubs 5.2. In the bottom 'Clubs' section, find the name of the club 5.3. check the 'Enrolled patrons' column ---> should not be equal to zero. 5.4 Click on 'Action' and choose the option “Enrollments” ---> The Enrollment fields created on step 2.6. are viewable in the table with their values Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 151820 [details] [review] Bug 25079: (QA follow-up) Fix TT issues Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 152496 [details] [review] Bug 25079: Add a 'edit' functionality to the Clubs tool in the staff interface A club enrollment can be cancel but it can't be edited This patch add a 'edit' functionality to the Clubs tool in the staff interface Test plan 1. Create a club template 1.1. Go to Tools > Patron clubs 1.2. Click on 'New Club Template' 1.3. Fill the form 1.4. on the 'Club fields' section, Click on Add new field 1.5. Fill in the form 1.6. on the 'Enrollment fields' section, Click on Add new field 1.7. Fill in the form 1.8. Click on Save button 2. Creation of the club 2.1. Go to Tools > Patron clubs > 'Clubs' section (bottom) 2.2. Click on the 'New Club' button and select the club template create on step 1 2.3. Fill in the form 2.4. Click on Save button 3. Club enrollement On the intranet 3.1. Search for a pratron and open the patron folder 3.2. Click on the 'Clubs' tab 3.3. Find the name of the club and click on 'Enroll' 3.4. Fill the questionnaire 3.5. Confirm registration ---> Note that the enrollement can be canceled but it cannot be modified 4. Apply the patch 5. Click one more time on the 'Clubs' tab ---> Note that the enrollement can now be modified Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 152497 [details] [review] Bug 25079: Show club enrollment question answers in staff client When a patron is enrolled in a patron club, koha collects answers to library-defined enrollment questions. Those answers go into the database but are not viewable outside of reports. This patch make those answers viewable on club-enrollments.pl. Test plan 1. Apply the patch 2. Create a club template 2.1. Go to Tools > Patron clubs 2.2. Click on 'New Club Template' 2.3. Fill the form 2.4. on the 'Club fields' section, Click on Add new field 2.5. Fill in the form 2.6. on the 'Enrollment fields' section, Click on Add new field 2.7. Fill in the form 2.8. Click on Save button 3. Creation of the club 3.1. Go to Tools > Patron clubs > 'Clubs' section (bottom) 3.2. Click on the 'New Club' button and select the club template create on step 1 3.3. Fill in the form 3.4. Click on Save button 4. Club enrollement On the intranet (or the OPAC if permitted) 4.1. Search for a pratron and open the patron folder 4.2. Click on the 'Clubs' tab 4.3. Find the name of the club and click on 'Enroll' 4.4. Fill the questionnaire 4.5. Confirm registration 5. Check registrations on the intranet 5.1. Go to Tools > Patron clubs 5.2. In the bottom 'Clubs' section, find the name of the club 5.3. check the 'Enrolled patrons' column ---> should not be equal to zero. 5.4 Click on 'Action' and choose the option “Enrollments” ---> The Enrollment fields created on step 2.6. are viewable in the table with their values Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 152498 [details] [review] Bug 25079: (QA follow-up) Fix TT issues Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebase Pushed to master for 23.11. Nice work everyone, thanks! *** Bug 31997 has been marked as a duplicate of this bug. *** Enhancement won't be backported to 23.05.x series |