| Summary: | Accessibility: The 'Your cart' page does not contain a level-one header | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | OPAC | Assignee: | Hayley Pelham <hayleypelham> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, bolshawh, hayleypelham, lucas, oleonard, sally.healey, victor |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.02, 19.11.08, 19.05.14
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 25150 | ||
| Attachments: |
Bug 25151: Fixing semantic headings in opac-basket.tt
Bug 25151: Fixing semantic headings in opac-basket.tt Bug 25151: Fixing semantic headings in opac-basket.tt |
||
Hi Martin, Could you please clarify where I can find the 'Your folder' page? I thought maybe you meant Lists, but that page has correct headings. Ah it's en-GB for the cart! Got it. Created attachment 105719 [details] [review] Bug 25151: Fixing semantic headings in opac-basket.tt Test plan: 1) Apply the patch 2) Add items to your cart/folder/basket 3) Open up the basket and check that the main heading is now an h1 4) Check that the page looks fine Thanks for jumping on this Hayley.. sorry it wasn't as clear as it should have been.. I'm working through a massive report and missed the translation in this case. Testing now for SO :). Hmm.. well this certainly improves the situation for screen readers and is exactly what I asked for.. but it seems to highlight some slightly odd css rules.. though at the moment I'm struggling to track down which ones are causing it. The 'h2' seems to appear larger than the 'h1' on the page.. which feel semantically incorrect visually. Created attachment 105766 [details] [review] Bug 25151: Fixing semantic headings in opac-basket.tt Test plan: 1) Apply the patch 2) Add items to your cart/folder/basket 3) Open up the basket and check that the main heading is now an h1 4) Check that the page looks fine Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 106118 [details] [review] Bug 25151: Fixing semantic headings in opac-basket.tt Test plan: 1) Apply the patch 2) Add items to your cart/folder/basket 3) Open up the basket and check that the main heading is now an h1 4) Check that the page looks fine Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.02 backported to 19.11.x for 19.11.08 Backported to 19.05.x branch for 19.05.14 |
Library Catalogue - OPAC 1/ Add items to your folder 2/ Once you have added some books, click on the 'Folder' at top of page to view selections. 3/ The ‘Your folder’ page does not contain a level-one heading. This means that users may not be able to accurately determine the structure of content on the page. Current Code: <h2>Your folder</h2> Solution: Ensure that all pages contain a heading level 1 to introduce the main content of the page followed by a logical hierarchy of subsequent headings. For example: <h1>Main heading</h1> <h2>Sub-heading of h1</h2> <h2>Sub-heading of h1</h2> <h3>Sub-heading of h2</h3> <h2>Sub-heading of h1</h2> <h3>Sub-heading of h2</h3> <h4>Sub-heading of h3</h4> <h2>Sub-heading of h1</h2> <h2>Sub-heading of h1</h2>