Summary: | subscription.closed is a boolean and must be tinyint(1) | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Database | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, martin.renvoize, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21294 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
Circulation function: | |||
Attachments: |
Bug 25152: Make subscription.closed tinyint(1)
Bug 25152: Make subscription.closed tinyint(1) |
Description
Jonathan Druart
2020-04-15 09:24:37 UTC
Created attachment 102976 [details] [review] Bug 25152: Make subscription.closed tinyint(1) https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans Boolean fields must be tinyint(1), not int(1) Created attachment 102987 [details] [review] Bug 25152: Make subscription.closed tinyint(1) https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans Boolean fields must be tinyint(1), not int(1) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice simple fix, going straight for PQA Note to self.. remember to add the boolean def in the schema class file upon push. Nice work everyone! Pushed to master for 20.05 (In reply to Martin Renvoize from comment #4) > Note to self.. remember to add the boolean def in the schema class file upon > push. Arg, I forgot that indeed! enhancement not backported to 19.11.x |