| Summary: | Accessibility: The 'Search results' page does not use heading markup where content is introduced | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | OPAC | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, bolshawh, lucas, oleonard, testopia, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.02, 19.11.08, 19.05.14
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 25153 | ||
| Attachments: |
Bug 25254: Add heading where content is introduced in opac-results.tt
Bug 25154: Add heading where content is introduced in opac-results.tt Bug 25154: Add heading where content is introduced in opac-results.tt Bug 25154: Add heading where content is introduced in opac-results.tt |
||
|
Description
Martin Renvoize (ashimema)
2020-04-15 09:31:41 UTC
Created attachment 105743 [details] [review] Bug 25254: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff I don't think we want to add the "maincontent" class to the <h2>. I think we should try to keep that class for container <div>s. Anyway, it's already added to the <div> right above the "[% IF ( searchdesc ) %]" block Created attachment 105768 [details] [review] Bug 25154: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff Good catch.. new patch uploaded. Created attachment 105770 [details] [review] Bug 25154: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 106122 [details] [review] Bug 25154: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! This patch fails the QA script for me: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt FAIL forbidden patterns forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 105) Which I do not understand because that line does include the aria-hidden attribute. I don't see how the QA script failure could be a problem, I am backporting this anyway since it improves accessibility. backported to 20.05.x for 20.05.02 backported to 19.11.x for 19.11.08 Backported to 19.05.x branch for 19.05.14 |