Summary: | Update OPAC search results pagination with aria labels | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.05.00
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 23003 | ||
Attachments: |
Bug 25234: Update OPAC search results pagination with aria labels
Bug 25234: Update OPAC search results pagination with aria labels Bug 25234: Update OPAC search results pagination with aria labels Bug 25234: Update OPAC search results pagination with aria labels |
Description
Owen Leonard
2020-04-21 21:18:56 UTC
Created attachment 103423 [details] [review] Bug 25234: Update OPAC search results pagination with aria labels This patch updates the include file which generates OPAC search results pagination so that it has better semantic markup and correct aria labels. To test, apply the patch and do a search in the OPAC which will return multiple pages of search results. View the source to confirm the markup changes: - <nav> instead of <div> surrounding the list of links, with a corresponding aria label - Navigation links should have labels indicating which page in the results they point to. - The current link should have "aria-disabled," and "aria-current" set. - Numbered links should have aria labels that indicate their number. I was testing this and caught one small typo that existed before this change: <a clas="page-num current" should be <a class="page-num current" Not 100% sure if we should fix that here or in a separate bug? Created attachment 103436 [details] [review] Bug 25234: Update OPAC search results pagination with aria labels This patch updates the include file which generates OPAC search results pagination so that it has better semantic markup and correct aria labels. To test, apply the patch and do a search in the OPAC which will return multiple pages of search results. View the source to confirm the markup changes: - <nav> instead of <div> surrounding the list of links, with a corresponding aria label - Navigation links should have labels indicating which page in the results they point to. - The current link should have "aria-disabled," and "aria-current" set. - Numbered links should have aria labels that indicate their number. (In reply to Lucas Gass from comment #2) > Not 100% sure if we should fix that here or in a separate bug? Easy enough to fix up the patch. Thanks for noticing it. Created attachment 103609 [details] [review] Bug 25234: Update OPAC search results pagination with aria labels This patch updates the include file which generates OPAC search results pagination so that it has better semantic markup and correct aria labels. To test, apply the patch and do a search in the OPAC which will return multiple pages of search results. View the source to confirm the markup changes: - <nav> instead of <div> surrounding the list of links, with a corresponding aria label - Navigation links should have labels indicating which page in the results they point to. - The current link should have "aria-disabled," and "aria-current" set. - Numbered links should have aria labels that indicate their number. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 103639 [details] [review] Bug 25234: Update OPAC search results pagination with aria labels This patch updates the include file which generates OPAC search results pagination so that it has better semantic markup and correct aria labels. To test, apply the patch and do a search in the OPAC which will return multiple pages of search results. View the source to confirm the markup changes: - <nav> instead of <div> surrounding the list of links, with a corresponding aria label - Navigation links should have labels indicating which page in the results they point to. - The current link should have "aria-disabled," and "aria-current" set. - Numbered links should have aria labels that indicate their number. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Always awesome to see some movement on accessibility, thanks Owe :) Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x |