|
Description
Martin Renvoize (ashimema)
2020-04-22 05:52:19 UTC
Created attachment 105726 [details] [review] Bug 25236: Fix semantic heading for opac-facets.inc Prior to this patch, the opac-facets side navigation box contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) > H5 (Headings within 'Refine your search' box) 3/ Apply this patch and follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 4/ Reload the page (Flushing the cache to ensure the CSS change load) 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) > H3 (Headings within 'Refine your search') 6/ Note the appearance of the box is still reasonable 7/ Signoff Created attachment 105727 [details] [review] Bug 25236: Fix semantic heading for opac-topissues.inc Prior to this patch, the opac-topissues side navigation box contained semantically incorrect headings. Test plan 0/ Enable 'OpacTopIssues' 1/ Navigate to the top issues page via the 'Most popular' link 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is still reasonable 7/ Signoff Created attachment 105728 [details] [review] Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Prior to this patch, the opac-full-serial-issues side navigation box contained semantically incorrect headings. Test plan 1/ Search for a serial with many linked issues 2/ Navigate to the detailed view of that serial 3/ Click on the 'More details' link after all the listed issues 4/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is improved and consistent with elsewhere 7/ Signoff Created attachment 105729 [details] [review] Bug 25236: Fix semantic heading for opac-facets.inc Prior to this patch, the opac-facets side navigation box contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) > H5 (Headings within 'Refine your search' box) 3/ Apply this patch and follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 4/ Reload the page (Flushing the cache to ensure the CSS change load) 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) > H3 (Headings within 'Refine your search') 6/ Note the appearance of the box is still reasonable 7/ Signoff Created attachment 105730 [details] [review] Bug 25236: Fix semantic heading for opac-topissues.inc Prior to this patch, the opac-topissues side navigation box contained semantically incorrect headings. Test plan 0/ Enable 'OpacTopIssues' 1/ Navigate to the top issues page via the 'Most popular' link 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is still reasonable 7/ Signoff Created attachment 105731 [details] [review] Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Prior to this patch, the opac-full-serial-issues side navigation box contained semantically incorrect headings. Test plan 1/ Search for a serial with many linked issues 2/ Navigate to the detailed view of that serial 3/ Click on the 'More details' link after all the listed issues 4/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is improved and consistent with elsewhere 7/ Signoff Created attachment 105760 [details] [review] Bug 25236: Fix semantic heading for opac-facets.inc Prior to this patch, the opac-facets side navigation box contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) > H5 (Headings within 'Refine your search' box) 3/ Apply this patch and follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 4/ Reload the page (Flushing the cache to ensure the CSS change load) 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) > H3 (Headings within 'Refine your search') 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 105761 [details] [review] Bug 25236: Fix semantic heading for opac-topissues.inc Prior to this patch, the opac-topissues side navigation box contained semantically incorrect headings. Test plan 0/ Enable 'OpacTopIssues' 1/ Navigate to the top issues page via the 'Most popular' link 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 105762 [details] [review] Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Prior to this patch, the opac-full-serial-issues side navigation box contained semantically incorrect headings. Test plan 1/ Search for a serial with many linked issues 2/ Navigate to the detailed view of that serial 3/ Click on the 'More details' link after all the listed issues 4/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is improved and consistent with elsewhere 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 106119 [details] [review] Bug 25236: Fix semantic heading for opac-facets.inc Prior to this patch, the opac-facets side navigation box contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) > H5 (Headings within 'Refine your search' box) 3/ Apply this patch and follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 4/ Reload the page (Flushing the cache to ensure the CSS change load) 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) > H3 (Headings within 'Refine your search') 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 106120 [details] [review] Bug 25236: Fix semantic heading for opac-topissues.inc Prior to this patch, the opac-topissues side navigation box contained semantically incorrect headings. Test plan 0/ Enable 'OpacTopIssues' 1/ Navigate to the top issues page via the 'Most popular' link 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 106121 [details] [review] Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Prior to this patch, the opac-full-serial-issues side navigation box contained semantically incorrect headings. Test plan 1/ Search for a serial with many linked issues 2/ Navigate to the detailed view of that serial 3/ Click on the 'More details' link after all the listed issues 4/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is improved and consistent with elsewhere 7/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.02 backported to 19.11.x for 19.11.08 Backported to 19.05.x branch for 19.05.14 |