Summary: | Accessibility: Multiple 'H1' headings exist in the full record display | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize <martin.renvoize> |
Component: | OPAC | Assignee: | Martin Renvoize <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | aleisha, bolshawh, hayleypelham, lucas, oleonard, testopia, victor |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.02, 19.11.08, 19.05.14
|
|
Bug Depends on: | |||
Bug Blocks: | 25237 | ||
Attachments: |
Bug 25238: Fix semantic heading for opac-details
Bug 25238: Fix semantic heading for opac-details Bug 25238: Fix semantic heading for opac-details |
Description
Martin Renvoize
2020-04-22 06:03:04 UTC
Created attachment 105733 [details] [review] Bug 25238: Fix semantic heading for opac-details Prior to this patch the opac-details view contained multiple h1 level headings. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that two H1 level headings are present (Page title + Item title) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and ntoe that the 'Item title' is now a level 2 heading 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled, MARC21, UNIMARC and NORMARC variations. Created attachment 105742 [details] [review] Bug 25238: Fix semantic heading for opac-details Prior to this patch the opac-details view contained multiple h1 level headings. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that two H1 level headings are present (Page title + Item title) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and ntoe that the 'Item title' is now a level 2 heading 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled, MARC21, UNIMARC and NORMARC variations. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I believe there was some discussion about the logo having h1 - was there any conclusion if we should change it? Created attachment 106117 [details] [review] Bug 25238: Fix semantic heading for opac-details Prior to this patch the opac-details view contained multiple h1 level headings. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that two H1 level headings are present (Page title + Item title) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and ntoe that the 'Item title' is now a level 2 heading 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled, MARC21, UNIMARC and NORMARC variations. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Katrin Fischer from comment #3) > I believe there was some discussion about the logo having h1 - was there any > conclusion if we should change it? I think we decided it would be good to change it, but not with this particular set of bugs as it needs more thought going into how we arrange subsequent headings. Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.02 backported to 19.11.x for 19.11.08 Backported to 19.05.x branch for 19.05.14 |