| Summary: | Accessibility: Checkboxes on the search results page do not contain specific aria labels | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | OPAC | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, bolshawh, hayleypelham, jonathan.druart, julian.maurice, lucas, oleonard, testopia, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26655 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.03, 19.11.09, 19.05.15
|
|
| Circulation function: | |||
| Bug Depends on: | 25922 | ||
| Bug Blocks: | 25243 | ||
| Attachments: |
Bug 25244: Add specific aria-label to search results
Bug 25244: Add specific aria-label to search results Bug 25244: Add specific aria-label to search results Bug 25244: (follow-up) QA corrections Bug 25244: Add specific aria-label to search results Bug 25244: (follow-up) QA corrections Bug 25244: Add specific aria-label to search results |
||
|
Description
Martin Renvoize (ashimema)
2020-04-22 06:56:12 UTC
Hi Martin, I think I'm missing something, but I can't see aria-label for the checkboxes in the Staff client or the OPAC, not in the code on the webpage nor in the source code. Could you please let me know how I can see what you're seeing for "Current code"? Interesting.. it looks like standard Koha is missing the aria labels entirely. Patch inbound Created attachment 106404 [details] [review] Bug 25244: Add specific aria-label to search results This patch adds an arai-lebel to the select checkboxes on the search results page of the OPAC. Test plan 1/ Perform a search that will yield some results 2/ Inspect the 'checkbox' on the left side of the results table 3/ Note that there is no arai-label 4/ Apply patch 5/ Refresh the search results page 6/ Inspect the 'checkbox' on the left side of the results table 7/ Note that the aria-label now appears and contains relavant information 8/ Signoff Created attachment 106406 [details] [review] Bug 25244: Add specific aria-label to search results This patch adds an arai-lebel to the select checkboxes on the search results page of the OPAC. Test plan 1/ Perform a search that will yield some results 2/ Inspect the 'checkbox' on the left side of the results table 3/ Note that there is no arai-label 4/ Apply patch 5/ Refresh the search results page 6/ Inspect the 'checkbox' on the left side of the results table 7/ Note that the aria-label now appears and contains relavant information 8/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Shouldn't it be "Select bibliographic record" ? I think the values of aria-label attributes are not automatically picked up by the translator, so it is not translatable. Also, QA script complains about missing TT filters (In reply to Julian Maurice from comment #5) > Shouldn't it be "Select bibliographic record" ? Hmm, perhaps "Select search result: ".. your right it's a bib record and not an item, but to an OPAC user I'm not sure they'd want to draw the difference.. it's used for selecting a result to place on hold etc. > > I think the values of aria-label attributes are not automatically picked up > by the translator, so it is not translatable. Good question.. I didn't think about that.. is that not a wider issue though.. we need aria-labels for accessibility.. we really ought to pick them for translations. > > Also, QA script complains about missing TT filters Oops.. I'll fix that. Created attachment 106499 [details] [review] Bug 25244: Add specific aria-label to search results This patch adds an arai-lebel to the select checkboxes on the search results page of the OPAC. Test plan 1/ Perform a search that will yield some results 2/ Inspect the 'checkbox' on the left side of the results table 3/ Note that there is no arai-label 4/ Apply patch 5/ Refresh the search results page 6/ Inspect the 'checkbox' on the left side of the results table 7/ Note that the aria-label now appears and contains relavant information 8/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 106500 [details] [review] Bug 25244: (follow-up) QA corrections Added bug 25922 to track the translation tools enhancement to allow the pickup of aria-labels for translation. Created attachment 106511 [details] [review] Bug 25244: Add specific aria-label to search results This patch adds an arai-lebel to the select checkboxes on the search results page of the OPAC. Test plan 1/ Perform a search that will yield some results 2/ Inspect the 'checkbox' on the left side of the results table 3/ Note that there is no arai-label 4/ Apply patch 5/ Refresh the search results page 6/ Inspect the 'checkbox' on the left side of the results table 7/ Note that the aria-label now appears and contains relavant information 8/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Created attachment 106512 [details] [review] Bug 25244: (follow-up) QA corrections Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Can we switch item for something else please? In German item (for holdings) and item (like a list item) are not the same word and there is not enough context to make sense for translation here. (In reply to Katrin Fischer from comment #12) > Can we switch item for something else please? In German item (for holdings) > and item (like a list item) are not the same word and there is not enough > context to make sense for translation here. I realized now, that the follow-up took care of this. Created attachment 107109 [details] [review] Bug 25244: Add specific aria-label to search results This patch adds an arai-lebel to the select checkboxes on the search results page of the OPAC. Test plan 1/ Perform a search that will yield some results 2/ Inspect the 'checkbox' on the left side of the results table 3/ Note that there is no arai-label 4/ Apply patch 5/ Refresh the search results page 6/ Inspect the 'checkbox' on the left side of the results table 7/ Note that the aria-label now appears and contains relavant information 8/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Bug 25244: (follow-up) QA corrections Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Patches squashed. Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.03 backported to 19.11.x for 19.11.09 Backported to 19.05.x branch for 19.05.15 |