| Summary: | When viewing a patron's modification log we should see both the MEMBERS and CIRCULATION modules | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | 1joynelson, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: |
20.05.00
|
Circulation function: | |
| Bug Depends on: | 19791, 25250 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 25249: (bug 19791 follow-up) Display Circulation log when showing patron's log
Bug 25249: (bug 19791 follow-up) Display Circulation log when showing patron's log Bug 25249: (bug 19791 follow-up) Display Circulation log when showing patron's log |
||
|
Description
Nick Clemens (kidclamp)
2020-04-22 12:36:55 UTC
Created attachment 103480 [details] [review] Bug 25249: (bug 19791 follow-up) Display Circulation log when showing patron's log When viewing a patron if you click the 'Modification log' tab you are presetned with both their circulation and members logs: https://staff.arcadiapl.bywatersolutions.com/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=CIRCULATION&object=152309&src=circ However, in bug 19791 the modules were locked to 'MEMBERS' if the src=circ We need to add CIRCULATION in as well Test plan: For master follow the test plan on bug 25250. Bug 24982 is not in stable branch, so test plan for stable branches: 1. Modify a patron, add them a fine, and do a checkout 2. Click the "Modification logs" => You see the Patrons and Circulation logs 3. Click submit => You see all patron logs only 4. Apply this patch 5. Click the "Modification logs" => You see the Patrons and Circulation logs 6. Click submit => You see the Patrons and Circulation logs Created attachment 103737 [details] [review] Bug 25249: (bug 19791 follow-up) Display Circulation log when showing patron's log When viewing a patron if you click the 'Modification log' tab you are presetned with both their circulation and members logs: https://staff.arcadiapl.bywatersolutions.com/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=CIRCULATION&object=152309&src=circ However, in bug 19791 the modules were locked to 'MEMBERS' if the src=circ We need to add CIRCULATION in as well Test plan: For master follow the test plan on bug 25250. Bug 24982 is not in stable branch, so test plan for stable branches: 1. Modify a patron, add them a fine, and do a checkout 2. Click the "Modification logs" => You see the Patrons and Circulation logs 3. Click submit => You see all patron logs only 4. Apply this patch 5. Click the "Modification logs" => You see the Patrons and Circulation logs 6. Click submit => You see the Patrons and Circulation logs Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Created attachment 103745 [details] [review] Bug 25249: (bug 19791 follow-up) Display Circulation log when showing patron's log When viewing a patron if you click the 'Modification log' tab you are presetned with both their circulation and members logs: https://staff.arcadiapl.bywatersolutions.com/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=CIRCULATION&object=152309&src=circ However, in bug 19791 the modules were locked to 'MEMBERS' if the src=circ We need to add CIRCULATION in as well Test plan: For master follow the test plan on bug 25250. Bug 24982 is not in stable branch, so test plan for stable branches: 1. Modify a patron, add them a fine, and do a checkout 2. Click the "Modification logs" => You see the Patrons and Circulation logs 3. Click submit => You see all patron logs only 4. Apply this patch 5. Click the "Modification logs" => You see the Patrons and Circulation logs 6. Click submit => You see the Patrons and Circulation logs Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work everyone! Pushed to master for 20.05 missing dependencies - not backported to 19.11.x |