| Summary: | Add script to export bib data to CollectionHQ | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Roberts <david.roberts> |
| Component: | Architecture, internals, and plumbing | Assignee: | David Roberts <david.roberts> |
| Status: | ASSIGNED --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | bgkriegel |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 25252: Add script to export bib data to CollectionHQ
Bug 25252: Add script to export bib data to CollectionHQ Bug 25252: Add script to export bib data to CollectionHQ Bug 25252: Add script to export bib data to CollectionHQ |
||
|
Description
David Roberts
2020-04-22 13:56:56 UTC
Created attachment 103482 [details] [review] Bug 25252: Add script to export bib data to CollectionHQ This script adds the capability to export bibliographic data to CollectionHQ via a cronjob. To test: 1) Apply the patch 2) Run the script and an export file should be created in /tmp 3) If you have a valid username and password for the CollectionHQ ftp server, add these credentials into lines 83 and 84 and run the script again to ensure it transfers correctly. Hi,
it works, data exported to /tmp, but
need an update in licence
FAIL misc/export2collectionhq.pl
OK critic
FAIL forbidden patterns
forbidden pattern: Koha is now under the GPLv3 license (line 9)
Also an usage/help(-h|--help) with a little description would be handy
Please fix and I'll test again
Created attachment 103671 [details] [review] Bug 25252: Add script to export bib data to CollectionHQ This script adds the capability to export bibliographic data to CollectionHQ via a cronjob. To test: 1) Apply the patch 2) Run the script and an export file should be created in /tmp 3) If you have a valid username and password for the CollectionHQ ftp server, add these credentials into lines 83 and 84 and run the script again to ensure it transfers correctly. I've changed the licence number and added a rudimentary help page. Thanks! There are 2 'my $result'
my $result = GetOptions(
'h|help' => \$want_help
);
my $result = GetOptions(
'h|help' => \$want_help
);
also some suggestion about encoding
FAIL misc/export2collectionhq.pl
FAIL critic
I/O layer ":utf8" used at line 52, column 1. Use ":encoding(UTF-8)" to get strict validation.
OK forbidden patterns
OK git manipulation
OK pod
OK spelling
FAIL valid
"my" variable $result masks earlier declaration in same scope
running with --help shows message but also the error
misc/export2collectionhq.pl --help
"my" variable $result masks earlier declaration in same scope at misc/export2collectionhq.pl line 48.
Sorry, I should have spotted the duplicated lines - it was a copy and paste job! I've also changed the encoding statement. I don't see the error when I run it with --help though - how are you testing it? Created attachment 103691 [details] [review] Bug 25252: Add script to export bib data to CollectionHQ This script adds the capability to export bibliographic data to CollectionHQ via a cronjob. To test: 1) Apply the patch 2) Run the script and an export file should be created in /tmp 3) If you have a valid username and password for the CollectionHQ ftp server, add these credentials into lines 83 and 84 and run the script again to ensure it transfers correctly. Created attachment 103705 [details] [review] Bug 25252: Add script to export bib data to CollectionHQ This script adds the capability to export bibliographic data to CollectionHQ via a cronjob. To test: 1) Apply the patch 2) Run the script and an export file should be created in /tmp 3) If you have a valid username and password for the CollectionHQ ftp server, add these credentials into lines 83 and 84 and run the script again to ensure it transfers correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> |