Bug 25277

Created attachment 103690 [details] [review]
Bug 25277: Don't specify a field in query if none passed

Created attachment 103698 [details] [review]
Bug 25277: Unit test

IIUC , it's about using Koha as a Z39.50 server.
https://wiki.koha-community.org/wiki/Setting_up_the_Z39.50_and_SRU_Server

Is it valid to test it with the same instance of Koha as a client? ^^"

(In reply to Victor Grousset/tuxayo from comment #3)
> IIUC , it's about using Koha as a Z39.50 server.
> https://wiki.koha-community.org/wiki/Setting_up_the_Z39.50_and_SRU_Server
> 
> Is it valid to test it with the same instance of Koha as a client? ^^"

Yes, you can test on your test environment

To test:
0 - Have Koha running with ES enabled
1 - Launch the z3950 responder:
    perl misc/z3950_responder.pl -c etc/z3950/ --debug
2 - Connect using yaz-client:
    yaz-client localhost:2100
3 - base biblios
4 - find bruce
5 - No results
6 - Stop the responder
7 - Apply patch
8 - Repeat
9 - This time you get results

You can also setup the localhost as a z39 search and search using the cataloguing module

For some reason I have issues to run the responder on koha-testing-docker

kohadev-koha@0c6291f3563f:/kohadevbox/koha$ perl misc/z3950_responder.pl -c etc/z3950/ --debug
/etc/koha/sites/kohadev/z3950/: No such file or directory

Why does it wants it from /etc/koha/sites/kohadev/z3950 ? It's like -c is ignored.

Same issue when using the koha-z3950-responder command.

kohadev-koha@0c6291f3563f:/kohadevbox/koha$ koha-z3950-responder --start kohadev
[....] Starting Z39.50/SRU daemon for kohadev:/etc/koha/sites/kohadev/z3950/: No such file or directory

I'm not specifying any param here. So it would be the default config of koha-testing-docker that doesn't pass it. Or it's ignored like above.

This ugly trick did it.
kohadev-koha@0c6291f3563f:/kohadevbox/koha$ ln -s /kohadevbox/koha/etc/z3950/ /etc/koha/sites/kohadev/z3950

Now it can try to test. But does anyone has an idea if that's and issue of Koha or koha-testing-docker?

Z> find learning
Sent searchRequest.
Received SearchResponse.
Search was a success.
Number of hits: 4, setno 6
records returned: 0
Elapsed: 0.038088

It's the number of hits right?


Z> find learning
Sent searchRequest.
Received SearchResponse.
Search was a success.
Number of hits: 4, setno 1
records returned: 0
Elapsed: 0.048846

Same results with the patch and restart_all done.


> You can also setup the localhost as a z39 search and search using the cataloguing module

I got 3 results that way.

Wait. I still get 3 results without applying the patch. (I recreated my dev env)

Maybe there is something wrong with my ES setup? Is there another way to see the current issue?

(In reply to Victor Grousset/tuxayo from comment #6:
> Maybe there is something wrong with my ES setup? Is there another way to see
> the current issue?

Are you certain your SearchEngine syspref is set to elastic? I can still recreate the issue

Step 1 should say:
perl misc/z3950_responder.pl --config-dir /kohadevbox/koha/etc/z3950 --debug

> Are you certain your SearchEngine syspref is set to elastic? I can still recreate the issue

Yes, I double checked that.

Z39.50 search gives me different results depending on the SearchEngine. But I always get results.

Created attachment 104293 [details] [review]
Bug 25277: Don't specify a field in query if none passed

== test plan ==
To test:
0 - Have Koha running with ES 6 enabled
1 - Launch the z3950 responder:
    perl misc/z3950_responder.pl --config-dir /kohadevbox/koha/etc/z3950 --debug
2 - Connect using yaz-client:
    yaz-client localhost:2100
2.1 Alternative, if you add the responder as a Z39.50 server in Koha and
  do a catalogue Z39.50 search. Don't forget to search in the keywords
  field. Not the title field.
3 - base biblios
4 - find bruce
5 - No results
6 - Stop the responder
7 - Apply patch
8 - Repeat
9 - This time you get results

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Created attachment 104294 [details] [review]
Bug 25277: Unit test

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Test plan added. It was compiled from the previous comment. And with this addition:

> 2.1 Alternative, if you add the responder as a Z39.50 server in Koha and
>   do a catalogue Z39.50 search. Don't forget to search in the keywords
>   field. Not the title field.

Created attachment 104942 [details] [review]
Bug 25277: Don't specify a field in query if none passed

== test plan ==
To test:
0 - Have Koha running with ES 6 enabled
1 - Launch the z3950 responder:
    perl misc/z3950_responder.pl --config-dir /kohadevbox/koha/etc/z3950 --debug
2 - Connect using yaz-client:
    yaz-client localhost:2100
2.1 Alternative, if you add the responder as a Z39.50 server in Koha and
  do a catalogue Z39.50 search. Don't forget to search in the keywords
  field. Not the title field.
3 - base biblios
4 - find bruce
5 - No results
6 - Stop the responder
7 - Apply patch
8 - Repeat
9 - This time you get results

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch: Removed unecessary () in the return statement

Created attachment 104943 [details] [review]
Bug 25277: Unit test

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Nice work everyone!

Pushed to master for 20.05

backported to 19.11.x for 19.11.06

missing dependencies for 19.05.x, no backport