| Summary: | Use modal confirmation when deleting a list in the OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 25280 | ||
| Bug Blocks: | 18117 | ||
| Attachments: |
Bug 25281: Use modal confirmation when deleting a list in the OPAC
Bug 25281: Use modal confirmation when deleting a list in the OPAC Bug 25281: Use modal confirmation when deleting a list in the OPAC Bug 25281: Use modal confirmation when deleting a list in the OPAC |
||
|
Description
Owen Leonard
2020-04-24 16:15:13 UTC
Created attachment 103704 [details] [review] Bug 25281: Use modal confirmation when deleting a list in the OPAC This patch modifies the process of deleting a list in the OPAC so that the deletion confirmation alert is replaced with a Bootstrap modal. In the process, I moved the repeated deletion form markup into a block To test, apply the patch and log in to the OPAC as a user who has multiple lists, including some which have been shared with other users. Go to the list of your lists and click the "Delete" link next to any of your lists. It should trigger a confirmation modal: - The modal should show the title of the list you're deleting. - If the list has titles on it, it show how many. - If the list has been shared with someone it should say so. Next, view a list which is not empty. - Test the "Delete list" link in the toolbar. - You should see the same information in the confirmation message as in the previous step. Do the same with a list which is empty. Created attachment 103708 [details] [review] Bug 25281: Use modal confirmation when deleting a list in the OPAC This patch modifies the process of deleting a list in the OPAC so that the deletion confirmation alert is replaced with a Bootstrap modal. In the process, I moved the repeated deletion form markup into a block To test, apply the patch and log in to the OPAC as a user who has multiple lists, including some which have been shared with other users. Go to the list of your lists and click the "Delete" link next to any of your lists. It should trigger a confirmation modal: - The modal should show the title of the list you're deleting. - If the list has titles on it, it show how many. - If the list has been shared with someone it should say so. Next, view a list which is not empty. - Test the "Delete list" link in the toolbar. - You should see the same information in the confirmation message as in the previous step. Do the same with a list which is empty. Created attachment 103709 [details] [review] Bug 25281: Use modal confirmation when deleting a list in the OPAC This patch modifies the process of deleting a list in the OPAC so that the deletion confirmation alert is replaced with a Bootstrap modal. In the process, I moved the repeated deletion form markup into a block To test, apply the patch and log in to the OPAC as a user who has multiple lists, including some which have been shared with other users. Go to the list of your lists and click the "Delete" link next to any of your lists. It should trigger a confirmation modal: - The modal should show the title of the list you're deleting. - If the list has titles on it, it show how many. - If the list has been shared with someone it should say so. Next, view a list which is not empty. - Test the "Delete list" link in the toolbar. - You should see the same information in the confirmation message as in the previous step. Do the same with a list which is empty. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 103715 [details] [review] Bug 25281: Use modal confirmation when deleting a list in the OPAC This patch modifies the process of deleting a list in the OPAC so that the deletion confirmation alert is replaced with a Bootstrap modal. In the process, I moved the repeated deletion form markup into a block To test, apply the patch and log in to the OPAC as a user who has multiple lists, including some which have been shared with other users. Go to the list of your lists and click the "Delete" link next to any of your lists. It should trigger a confirmation modal: - The modal should show the title of the list you're deleting. - If the list has titles on it, it show how many. - If the list has been shared with someone it should say so. Next, view a list which is not empty. - Test the "Delete list" link in the toolbar. - You should see the same information in the confirmation message as in the previous step. Do the same with a list which is empty. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 not backported to 19.11 |