Summary: | Consistent return value in K::A::Order->current_item_level_holds | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
Circulation function: | |||
Bug Depends on: | 24440, 25296 | ||
Bug Blocks: | 20212 | ||
Attachments: |
Bug 25297: Regression tests
Bug 25297: Consistent return value in K::A::Order->current_item_level_holds Bug 25297: Regression tests Bug 25297: Consistent return value in K::A::Order->current_item_level_holds Bug 25297: Regression tests Bug 25297: Consistent return value in K::A::Order->current_item_level_holds |
Description
Tomás Cohen Arazi (tcohen)
2020-04-27 21:53:46 UTC
Created attachment 103813 [details] [review] Bug 25297: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 103814 [details] [review] Bug 25297: Consistent return value in K::A::Order->current_item_level_holds This patch makes the return values for 'current_item_level_holds' consistent: they will always be a Koha::Holds iterator. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Order.t => FAIL: It doesn't work as expected, cannot call ->count on undef, etc 3. Apply this patch 4. Repeat 2. => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> *** Bug 24965 has been marked as a duplicate of this bug. *** Created attachment 104008 [details] [review] Bug 25297: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Created attachment 104009 [details] [review] Bug 25297: Consistent return value in K::A::Order->current_item_level_holds This patch makes the return values for 'current_item_level_holds' consistent: they will always be a Koha::Holds iterator. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Order.t => FAIL: It doesn't work as expected, cannot call ->count on undef, etc 3. Apply this patch 4. Repeat 2. => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Created attachment 104014 [details] [review] Bug 25297: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 104015 [details] [review] Bug 25297: Consistent return value in K::A::Order->current_item_level_holds This patch makes the return values for 'current_item_level_holds' consistent: they will always be a Koha::Holds iterator. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Order.t => FAIL: It doesn't work as expected, cannot call ->count on undef, etc 3. Apply this patch 4. Repeat 2. => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 not backported to 19.11.x |